Source/core/html/HTMLInputElement.h - Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.h

Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLInputElement.h

diff --git a/Source/core/html/HTMLInputElement.h b/Source/core/html/HTMLInputElement.h

index 0fb3a1cd12eb7afe1a9cabe3c11df0c4e056c0d1..12a95273b10bb7397071c5ba2de5ed3b7cba47c0 100644

--- a/Source/core/html/HTMLInputElement.h

+++ b/Source/core/html/HTMLInputElement.h

@@ -138,8 +138,8 @@ public:

void setValueFromRenderer(const String&);

- int selectionStartForBinding(ExceptionState&) const;

- int selectionEndForBinding(ExceptionState&) const;

+ unsigned selectionStartForBinding(ExceptionState&) const;

+ unsigned selectionEndForBinding(ExceptionState&) const;

String selectionDirectionForBinding(ExceptionState&) const;

void setSelectionStartForBinding(int, ExceptionState&);

void setSelectionEndForBinding(int, ExceptionState&);

« no previous file with comments | « LayoutTests/fast/forms/selection-start-end-readonly-expected.txt ('k') | Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »