Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1267113002: PopupMenuImpl should get menu items via PopupMenuClient. (Closed)

Created:
5 years, 4 months ago by tkent
Modified:
5 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-html_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, blink-reviews-rendering, jchaffraix+rendering
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

PopupMenuImpl should get menu items via PopupMenuClient. We should not have item iteration code in multiple classes, and should refer to HTMLSelectElement::m_listItems. This CL has no behavior changes. BUG=515013 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -30 lines) Patch
M Source/core/html/forms/PopupMenuClient.h View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutMenuList.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutMenuList.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/web/ExternalPopupMenuTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/PopupMenuImpl.cpp View 9 chunks +34 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Keishi, would you review this please?
5 years, 4 months ago (2015-08-03 07:06:30 UTC) #2
keishi
LGTM
5 years, 4 months ago (2015-08-03 07:45:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267113002/1
5 years, 4 months ago (2015-08-03 08:07:01 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 08:50:46 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199888

Powered by Google App Engine
This is Rietveld 408576698