Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Unified Diff: Source/web/ExternalPopupMenuTest.cpp

Issue 1267113002: PopupMenuImpl should get menu items via PopupMenuClient. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/LayoutMenuList.cpp ('k') | Source/web/PopupMenuImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ExternalPopupMenuTest.cpp
diff --git a/Source/web/ExternalPopupMenuTest.cpp b/Source/web/ExternalPopupMenuTest.cpp
index 3a9e9175a24d7bfa2355dd2c23eae87604f4b5a3..b3ab7fa2c83a3fabd81c9586cc762207dd82434a 100644
--- a/Source/web/ExternalPopupMenuTest.cpp
+++ b/Source/web/ExternalPopupMenuTest.cpp
@@ -36,6 +36,7 @@ public:
void selectionChanged(unsigned listIndex, bool fireEvents = true) override { }
void selectionCleared() override { }
+ Element& itemElement(unsigned listIndex) const override { return *m_ownerElement->listItems()[listIndex]; }
String itemText(unsigned listIndex) const override { return emptyString(); }
String itemToolTip(unsigned listIndex) const override { return emptyString(); }
String itemAccessibilityText(unsigned listIndex) const override { return emptyString(); }
@@ -54,7 +55,6 @@ public:
bool multiple() const override { return false; }
IntRect elementRectRelativeToViewport() const override { return IntRect(); }
Element& ownerElement() const override { return *m_ownerElement; }
- const ComputedStyle* computedStyleForItem(Element& element) const override { return nullptr; }
const ComputedStyle* computedStyleForItem(unsigned listIndex) const override
{
Element* element = m_ownerElement->listItems()[listIndex];
« no previous file with comments | « Source/core/layout/LayoutMenuList.cpp ('k') | Source/web/PopupMenuImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698