PopupMenuImpl should get menu items via PopupMenuClient.

Source/core/layout/LayoutMenuList.cpp

 /*
  * This file is part of the select element layoutObject in WebCore.
  *
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *               2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 382 matching lines @@
     // We don't use absoluteBoundingBoxRect() because it can return an IntRect
     // larger the actual size by 1px.
     return selectElement()->document().view()->contentsToViewport(roundedIntRect(absoluteBoundingBoxFloatRect()));
 }
 
 Element& LayoutMenuList::ownerElement() const
 {
     return *selectElement();
 }
 
-const ComputedStyle* LayoutMenuList::computedStyleForItem(Element& element) const
-{
-    return element.computedStyle() ? element.computedStyle() : element.ensureComputedStyle();
-}
-
 const ComputedStyle* LayoutMenuList::computedStyleForItem(unsigned listIndex) const
 {
     Element& element = *selectElement()->listItems()[listIndex];
     return element.computedStyle() ? element.computedStyle() : element.ensureComputedStyle();
 }
 
 void LayoutMenuList::didSetSelectedIndex(int listIndex)
 {
     didUpdateActiveOption(selectElement()->listToOptionIndex(listIndex));
 }
@@ skipping 15 matching lines @@
     // We skip sending accessiblity notifications for the very first option, otherwise
     // we get extra focus and select events that are undesired.
     if (!m_hasUpdatedActiveOption) {
         m_hasUpdatedActiveOption = true;
         return;
     }
 
     document().existingAXObjectCache()->handleUpdateActiveMenuOption(this, optionIndex);
 }
 
+Element& LayoutMenuList::itemElement(unsigned listIndex) const
+{
+    return *selectElement()->listItems()[listIndex];
+}
+
 String LayoutMenuList::itemText(unsigned listIndex) const
 {
     HTMLSelectElement* select = selectElement();
     const WillBeHeapVector<RawPtrWillBeMember<HTMLElement>>& listItems = select->listItems();
     if (listIndex >= listItems.size())
         return String();
 
     String itemString;
     Element* element = listItems[listIndex];
     if (isHTMLOptGroupElement(*element))
@@ skipping 40 matching lines @@
         return false;
 
     return !element->isDisabledFormControl();
 }
 
 bool LayoutMenuList::itemIsDisplayNone(unsigned listIndex) const
 {
     Element& element = *selectElement()->listItems()[listIndex];
     if (isHTMLOptionElement(element))
         return toHTMLOptionElement(element).isDisplayNone();
-    if (const ComputedStyle* style = computedStyleForItem(element))
+    if (const ComputedStyle* style = computedStyleForItem(listIndex))
         return style->display() == NONE;
     return false;
 }
 
 LayoutUnit LayoutMenuList::clientPaddingLeft() const
 {
     return paddingLeft() + m_innerBlock->paddingLeft();
 }
 
 const int endOfLinePadding = 2;
@@ skipping 56 matching lines @@
     HTMLElement* element = listItems[listIndex];
     return isHTMLOptionElement(*element) && toHTMLOptionElement(*element).selected();
 }
 
 void LayoutMenuList::provisionalSelectionChanged(unsigned listIndex)
 {
     setIndexToSelectOnCancel(listIndex);
 }
 
 } // namespace blink