Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 1261403002: Add paper-menu-button and its dependencies to third_party/polymer (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
CC:
chromium-reviews, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add paper-menu-button and its dependencies to third_party/polymer And run reproduce.sh and all that stuff Test fixes by Tim Sergeant (tsergeant@chromium.org) https://codereview.chromium.org/1254803006/ R=jlklein@chromium.org BUG=425626 Committed: https://crrev.com/88bd0fa432c7d136e4b3178b679ae8fb2e935464 Cr-Commit-Position: refs/heads/master@{#341293}

Patch Set 1 #

Total comments: 3

Patch Set 2 : +hero.svg #

Patch Set 3 : reproduce.sh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2276 lines, -920 lines) Patch
M chrome/test/data/pdf/material_elements_test.js View 1 1 chunk +33 lines, -33 lines 0 comments Download
M third_party/polymer/v1_0/bower.json View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/hero.svg View 2 1 chunk +33 lines, -33 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-behaviors/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-behaviors/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-behaviors/iron-button-state-extracted.js View 2 chunks +29 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-collapse/hero.svg View 2 1 chunk +23 lines, -23 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-dropdown/.bower.json View 1 1 chunk +48 lines, -0 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-dropdown/.gitignore View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-dropdown/README.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-dropdown/bower.json View 1 1 chunk +39 lines, -0 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-dropdown/index.html View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown.html View 1 1 chunk +66 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown-extracted.js View 1 1 chunk +278 lines, -0 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown-scroll-manager.html View 1 1 chunk +1 line, -2 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown-scroll-manager-extracted.js View 1 1 chunk +208 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-flex-layout/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-form-element-behavior/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icon/hero.svg View 2 1 chunk +19 lines, -19 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/hero.svg View 2 1 chunk +35 lines, -35 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-input/hero.svg View 2 1 chunk +19 lines, -19 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-media-query/hero.svg View 2 1 chunk +29 lines, -29 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-meta/hero.svg View 2 1 chunk +33 lines, -33 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-pages/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-pages/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-pages/hero.svg View 2 1 chunk +22 lines, -22 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-pages/iron-pages-extracted.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-selector/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/hero.svg View 2 1 chunk +51 lines, -51 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog/hero.svg View 2 1 chunk +58 lines, -58 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-drawer-panel/hero.svg View 2 1 chunk +21 lines, -21 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/.bower.json View 3 chunks +11 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/bower.json View 2 chunks +8 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/hero.svg View 2 1 chunk +38 lines, -38 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-header-panel/paper-header-panel.css View 1 1 chunk +131 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/paper-header-panel.html View 1 chunk +7 lines, -119 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/paper-header-panel-extracted.js View 4 chunks +11 lines, -11 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/hero.svg View 2 1 chunk +19 lines, -19 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-menu-button/.bower.json View 1 1 chunk +53 lines, -0 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/paper-menu-button/.gitignore View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-menu-button/README.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-menu-button/bower.json View 1 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-menu-button/hero.svg View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/paper-menu-button/index.html View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button.html View 1 1 chunk +107 lines, -0 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button-animations.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button-animations-extracted.js View 1 1 chunk +93 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button-extracted.js View 1 1 chunk +150 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu/hero.svg View 2 1 chunk +35 lines, -35 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/README.md View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/hero.svg View 2 1 chunk +21 lines, -21 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/paper-progress.html View 4 chunks +77 lines, -9 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/paper-progress-extracted.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/hero.svg View 2 1 chunk +22 lines, -22 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button-extracted.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-group/hero.svg View 2 1 chunk +25 lines, -25 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-ripple/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-ripple/hero.svg View 2 1 chunk +30 lines, -30 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/hero.svg View 2 1 chunk +20 lines, -20 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-spinner/hero.svg View 2 1 chunk +27 lines, -27 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-styles/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-styles/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-styles/color.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tabs/hero.svg View 2 1 chunk +23 lines, -23 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/hero.svg View 2 1 chunk +22 lines, -22 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer-externs/.bower.json View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer-externs/polymer.externs.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/build.log View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/polymer-extracted.js View 21 chunks +72 lines, -39 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/polymer-micro-extracted.js View 3 chunks +15 lines, -10 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/polymer-mini-extracted.js View 6 chunks +58 lines, -16 lines 0 comments Download
M third_party/polymer/v1_0/reproduce.sh View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (8 generated)
Dan Beam
5 years, 4 months ago (2015-07-29 23:10:18 UTC) #1
Jeremy Klein
lgtm https://memegen.googleplex.com/5882545718689792 https://codereview.chromium.org/1261403002/diff/1/third_party/polymer/v1_0/bower.json File third_party/polymer/v1_0/bower.json (right): https://codereview.chromium.org/1261403002/diff/1/third_party/polymer/v1_0/bower.json#newcode21 third_party/polymer/v1_0/bower.json:21: "iron-image": "PolymerElements/iron-image#1.0.2", Do we need iron-image for ...
5 years, 4 months ago (2015-07-29 23:25:58 UTC) #2
Dan Beam
https://codereview.chromium.org/1261403002/diff/1/third_party/polymer/v1_0/bower.json File third_party/polymer/v1_0/bower.json (right): https://codereview.chromium.org/1261403002/diff/1/third_party/polymer/v1_0/bower.json#newcode21 third_party/polymer/v1_0/bower.json:21: "iron-image": "PolymerElements/iron-image#1.0.2", On 2015/07/29 23:25:58, Jeremy Klein wrote: > ...
5 years, 4 months ago (2015-07-29 23:35:58 UTC) #3
Dan Beam
tsergeant@: any ideas why this update is breaking the MD PDF UI? https://www.polymer-project.org/1.0/docs/release-notes.html
5 years, 4 months ago (2015-07-30 02:53:45 UTC) #4
michaelpg
https://codereview.chromium.org/1261403002/diff/1/third_party/polymer/v1_0/bower.json File third_party/polymer/v1_0/bower.json (right): https://codereview.chromium.org/1261403002/diff/1/third_party/polymer/v1_0/bower.json#newcode21 third_party/polymer/v1_0/bower.json:21: "iron-image": "PolymerElements/iron-image#1.0.2", On 2015/07/29 23:35:58, Dan Beam wrote: > ...
5 years, 4 months ago (2015-07-30 03:17:09 UTC) #6
tsergeant
On 2015/07/30 at 02:53:45, dbeam wrote: > tsergeant@: any ideas why this update is breaking ...
5 years, 4 months ago (2015-07-30 03:18:11 UTC) #7
Dan Beam
+dzhioev@ for third_party/polymer/OWNERS
5 years, 4 months ago (2015-07-30 23:54:43 UTC) #13
dzhioev (left Google)
On 2015/07/30 23:54:43, Dan Beam wrote: > +dzhioev@ for third_party/polymer/OWNERS So, what have you done ...
5 years, 4 months ago (2015-07-31 01:01:54 UTC) #14
Dan Beam
On 2015/07/31 01:01:54, dzhioev wrote: > On 2015/07/30 23:54:43, Dan Beam wrote: > > +dzhioev@ ...
5 years, 4 months ago (2015-07-31 01:03:42 UTC) #15
dzhioev (left Google)
On 2015/07/31 01:03:42, Dan Beam wrote: > On 2015/07/31 01:01:54, dzhioev wrote: > > On ...
5 years, 4 months ago (2015-07-31 01:13:19 UTC) #16
Dan Beam
On 2015/07/31 01:13:19, dzhioev wrote: > On 2015/07/31 01:03:42, Dan Beam wrote: > > On ...
5 years, 4 months ago (2015-07-31 01:20:23 UTC) #17
dzhioev (left Google)
On 2015/07/31 01:20:23, Dan Beam wrote: > On 2015/07/31 01:13:19, dzhioev wrote: > > On ...
5 years, 4 months ago (2015-07-31 04:20:45 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261403002/60002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261403002/60002
5 years, 4 months ago (2015-07-31 06:37:38 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:60002)
5 years, 4 months ago (2015-07-31 07:45:55 UTC) #22
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 07:46:35 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/88bd0fa432c7d136e4b3178b679ae8fb2e935464
Cr-Commit-Position: refs/heads/master@{#341293}

Powered by Google App Engine
This is Rietveld 408576698