Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1266443007: MD downloads: implement incognito markers (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
tommycli
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dl-menu2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD downloads: implement incognito markers R=tommycli@chromium.org BUG=425626 Committed: https://crrev.com/5e22f0c8a9488d91fdb016d8abf5b6eb5208d174 Cr-Commit-Position: refs/heads/master@{#341447}

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/item.css View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 1 chunk +3 lines, -0 lines 6 comments Download
M chrome/browser/resources/md_downloads/item.js View 2 chunks +10 lines, -1 line 0 comments Download
D chrome/browser/resources/ntp4/images/2x/incognito_icon.png View Binary file 0 comments Download
D chrome/browser/resources/ntp4/images/incognito_icon.png View Binary file 0 comments Download
M chrome/browser/resources/ntp4/incognito_tab.css View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/webui/resources/images/2x/incognito_icon.png View Binary file 0 comments Download
A + ui/webui/resources/images/incognito_icon.png View Binary file 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (1 generated)
Dan Beam
5 years, 4 months ago (2015-07-31 22:30:54 UTC) #1
Dan Beam
screenshot: http://i.imgur.com/vG2yEwC.png
5 years, 4 months ago (2015-07-31 22:33:52 UTC) #2
tommycli
https://codereview.chromium.org/1266443007/diff/1/chrome/browser/resources/md_downloads/item.html File chrome/browser/resources/md_downloads/item.html (right): https://codereview.chromium.org/1266443007/diff/1/chrome/browser/resources/md_downloads/item.html#newcode67 chrome/browser/resources/md_downloads/item.html:67: hidden$="[[!isIncognito_]]"></div> $= ?
5 years, 4 months ago (2015-07-31 22:37:50 UTC) #3
Dan Beam
https://codereview.chromium.org/1266443007/diff/1/chrome/browser/resources/md_downloads/item.html File chrome/browser/resources/md_downloads/item.html (right): https://codereview.chromium.org/1266443007/diff/1/chrome/browser/resources/md_downloads/item.html#newcode39 chrome/browser/resources/md_downloads/item.html:39: <div id="safe" class="controls" hidden$="[[isDangerous_]]"> ^ https://codereview.chromium.org/1266443007/diff/1/chrome/browser/resources/md_downloads/item.html#newcode56 chrome/browser/resources/md_downloads/item.html:56: <div id="dangerous" ...
5 years, 4 months ago (2015-07-31 22:39:51 UTC) #4
tommycli
On 2015/07/31 22:39:51, Dan Beam wrote: > https://codereview.chromium.org/1266443007/diff/1/chrome/browser/resources/md_downloads/item.html > File chrome/browser/resources/md_downloads/item.html (right): > > https://codereview.chromium.org/1266443007/diff/1/chrome/browser/resources/md_downloads/item.html#newcode39 ...
5 years, 4 months ago (2015-07-31 22:40:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266443007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266443007/1
5 years, 4 months ago (2015-07-31 23:53:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-01 00:25:03 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-01 00:25:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e22f0c8a9488d91fdb016d8abf5b6eb5208d174
Cr-Commit-Position: refs/heads/master@{#341447}

Powered by Google App Engine
This is Rietveld 408576698