Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1264543006: Port SkXfermode opts to SkOpts.h (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
djsollen, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Port SkXfermode opts to SkOpts.h Renames Sk4pxXfermode.h to SkXfermode_opts.h, and refactors it a tiny bit internally. This moves xfermode optimization from being "compile-time everywhere but NEON" to simply "runtime everywhere". I don't anticipate any effect on perf or correctness. BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/490b61569d27c9b7ba164fbc4394994d2e7cb022

Patch Set 1 #

Patch Set 2 : Break the cycle. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -437 lines) Patch
M gyp/opts.gypi View 6 chunks +0 lines, -7 lines 0 comments Download
M include/core/SkFloatingPoint.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M include/private/SkOpts.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
D src/core/Sk4pxXfermode.h View 1 chunk +0 lines, -330 lines 0 comments Download
M src/core/SkOpts.cpp View 1 2 chunks +5 lines, -4 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 2 2 chunks +2 lines, -17 lines 0 comments Download
M src/opts/SkOpts_neon.cpp View 1 2 chunks +6 lines, -4 lines 0 comments Download
M src/opts/SkOpts_sse2.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
A + src/opts/SkXfermode_opts.h View 3 chunks +1 line, -10 lines 0 comments Download
D src/opts/SkXfermode_opts_arm.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
D src/opts/SkXfermode_opts_arm_neon.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
D src/opts/SkXfermode_opts_none.cpp View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264543006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264543006/40001
5 years, 4 months ago (2015-07-31 18:16:24 UTC) #2
mtklein_C
5 years, 4 months ago (2015-07-31 18:21:09 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-31 18:24:25 UTC) #6
djsollen
lgtm
5 years, 4 months ago (2015-07-31 18:45:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264543006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264543006/40001
5 years, 4 months ago (2015-07-31 18:48:16 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 18:50:29 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/490b61569d27c9b7ba164fbc4394994d2e7cb022

Powered by Google App Engine
This is Rietveld 408576698