Unflake CustomTabTests

Unflake CustomTabTests

We were adding an observer and eaiting for pageLoadFinished without
first checking that it has already finished. This only waits
if the page isn't loading

BUG=519613
Committed: https://crrev.com/f59c173f7b89463b8655ab1f239dc1339a1a827e
Cr-Commit-Position: refs/heads/master@{#342925}

[Yusuf, 2015-08-11 22:25:18]

yusufo@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2015-08-11 22:25:51]

lgtm

[Yusuf, 2015-08-11 22:27:09]

The CQ bit was checked by yusufo@chromium.org

[commit-bot: I haz the power, 2015-08-11 22:27:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1278403008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1278403008/1

[Ian Wen, 2015-08-11 22:28:59]

ianwen@chromium.org changed reviewers:
+ ianwen@chromium.org

[Ian Wen, 2015-08-11 22:28:59]

https://codereview.chromium.org/1278403008/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java
(right):

https://codereview.chromium.org/1278403008/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java:70:
if (!tab.isLoadingAndRenderingDone()) pageLoadFinishedHelper.waitForCallback(0);
Does this mean our loading is too fast and by this line the loading has already
finished?

[Yusuf, 2015-08-11 22:31:22]

https://codereview.chromium.org/1278403008/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java
(right):

https://codereview.chromium.org/1278403008/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java:70:
if (!tab.isLoadingAndRenderingDone()) pageLoadFinishedHelper.waitForCallback(0);
On 2015/08/11 22:28:59, Ian Wen wrote:
> Does this mean our loading is too fast and by this line the loading has
already
> finished?

yes. usually about:blank is pretty fast :)

[commit-bot: I haz the power, 2015-08-11 22:56:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-11 22:57:06]

Patchset 1 (id:??) landed as
https://crrev.com/f59c173f7b89463b8655ab1f239dc1339a1a827e
Cr-Commit-Position: refs/heads/master@{#342925}