chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java - Issue 1263573011: Let client specify content description for custom action button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

Issue 1263573011: Let client specify content description for custom action button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix corresponding test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

index bd3b9630e12cf66f2a8e53d9596cb3a56ac8f028..5893650c44602eed7b6df6988bff9b2188292e9c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

@@ -399,13 +399,13 @@ public class ToolbarPhone extends ToolbarLayout

@Override

public boolean onLongClick(View v) {

- int stringResourceId = 0;

+ CharSequence description = null;

if (v == mToggleTabStackButton) {

- stringResourceId = R.string.open_tabs;

+ description = getResources().getString(R.string.open_tabs);

} else {

return false;

}

- return showAccessibilityToast(v, stringResourceId);

+ return showAccessibilityToast(v, description);

}

@Override