Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1262583002: Reland of "Remove ExternalArray, derived types, and element kinds" (Closed)

Created:
5 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "Remove ExternalArray, derived types, and element kinds" Original issue's description: > Remove ExternalArray, derived types, and element kinds > > BUG=v8:3996 > R=jarin@chromium.org, mvstanton@chromium.org, bmeurer@chromium.org > LOG=y > > Committed: https://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c > Cr-Commit-Position: refs/heads/master@{#29872} BUG=v8:3996 R=bmeurer@chromium.org LOG=y Committed: https://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9 Cr-Commit-Position: refs/heads/master@{#29893}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -1892 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-arm.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/arm/lithium-arm.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 8 chunks +6 lines, -32 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 3 chunks +4 lines, -26 lines 0 comments Download
M src/bootstrapper.cc View 4 chunks +10 lines, -24 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 5 chunks +1 line, -60 lines 0 comments Download
M src/compiler/access-builder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M src/contexts.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/elements.cc View 5 chunks +0 lines, -35 lines 0 comments Download
M src/elements-kind.h View 4 chunks +5 lines, -32 lines 0 comments Download
M src/elements-kind.cc View 4 chunks +6 lines, -39 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/factory.cc View 3 chunks +9 lines, -13 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/heap/heap.h View 4 chunks +3 lines, -31 lines 0 comments Download
M src/heap/heap.cc View 12 chunks +16 lines, -82 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 9 chunks +23 lines, -35 lines 0 comments Download
M src/hydrogen-instructions.h View 8 chunks +15 lines, -42 lines 0 comments Download
M src/hydrogen-instructions.cc View 6 chunks +9 lines, -15 lines 0 comments Download
M src/hydrogen-uint32-analysis.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 5 chunks +6 lines, -28 lines 0 comments Download
M src/ia32/lithium-ia32.h View 3 chunks +2 lines, -16 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ic/ic.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/ic/ic-compiler.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/lookup.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 9 chunks +6 lines, -32 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/mips/lithium-mips.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 9 chunks +6 lines, -32 lines 0 comments Download
M src/mips64/lithium-mips64.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M src/objects.h View 10 chunks +6 lines, -315 lines 0 comments Download
M src/objects.cc View 1 23 chunks +26 lines, -193 lines 0 comments Download
M src/objects-debug.cc View 3 chunks +6 lines, -14 lines 0 comments Download
M src/objects-inl.h View 9 chunks +4 lines, -255 lines 0 comments Download
M src/objects-printer.cc View 3 chunks +0 lines, -31 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 17 chunks +6 lines, -32 lines 0 comments Download
M src/ppc/lithium-ppc.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +1 line, -11 lines 0 comments Download
M src/runtime/runtime-array.cc View 5 chunks +1 line, -53 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +1 line, -12 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 5 chunks +14 lines, -23 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 5 chunks +6 lines, -28 lines 0 comments Download
M src/x64/lithium-x64.h View 3 chunks +2 lines, -16 lines 0 comments Download
M src/x64/lithium-x64.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 6 chunks +6 lines, -28 lines 0 comments Download
M src/x87/lithium-x87.h View 3 chunks +2 lines, -16 lines 0 comments Download
M src/x87/lithium-x87.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M test/cctest/compiler/test-run-properties.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M test/cctest/test-api.cc View 9 chunks +18 lines, -18 lines 0 comments Download
M test/mjsunit/elements-kind.js View 3 chunks +9 lines, -46 lines 0 comments Download
M test/mjsunit/opt-elements-kind.js View 2 chunks +32 lines, -33 lines 0 comments Download
M test/mjsunit/osr-elements-kind.js View 2 chunks +32 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
ptal 2nd patchset contains fix in JSTypedArray::GetBuffer() to not try to externalize an already neutered ...
5 years, 4 months ago (2015-07-28 08:24:24 UTC) #1
Benedikt Meurer
LGTM.
5 years, 4 months ago (2015-07-28 09:26:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262583002/20001
5 years, 4 months ago (2015-07-28 09:27:09 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-28 09:29:40 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 09:30:08 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fded08f6949ac3f673f64d3e36be5d03800660e9
Cr-Commit-Position: refs/heads/master@{#29893}

Powered by Google App Engine
This is Rietveld 408576698