Reland of "Remove ExternalArray, derived types, and element kinds"

test/cctest/compiler/test-run-properties.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "test/cctest/compiler/function-tester.h"
 
 using namespace v8::internal;
 using namespace v8::internal::compiler;
 
 template <typename U>
 static void TypedArrayLoadHelper(const char* array_type) {
   static const uint32_t kValues[] = {
       0x00000000, 0x00000001, 0x00000023, 0x00000042, 0x12345678, 0x87654321,
       0x0000003f, 0x0000007f, 0x00003fff, 0x00007fff, 0x3fffffff, 0x7fffffff,
       0x000000ff, 0x00000080, 0x0000ffff, 0x00008000, 0xffffffff, 0x80000000};
   EmbeddedVector<char, 1024> values_buffer;
   StringBuilder values_builder(values_buffer.start(), values_buffer.length());
   for (size_t i = 0; i < arraysize(kValues); ++i) {
     values_builder.AddFormatted("a[%d] = 0x%08x;", i, kValues[i]);
   }
 
-  // Note that below source creates two different typed arrays with distinct
-  // elements kind to get coverage for both access patterns:
-  // - IsFixedTypedArrayElementsKind(x)
-  // - IsExternalArrayElementsKind(y)
+  // Note that below source creates two different typed arrays with the same
+  // elements kind to get coverage for both (on heap / with external backing
+  // store) access patterns.
   const char* source =
       "(function(a) {"
       "  var x = (a = new %sArray(%d)); %s;"
       "  var y = (a = new %sArray(%d)); %s; %%TypedArrayGetBuffer(y);"
       "  if (!%%HasFixed%sElements(x)) %%AbortJS('x');"
-      "  if (!%%HasExternal%sElements(y)) %%AbortJS('y');"
+      "  if (!%%HasFixed%sElements(y)) %%AbortJS('y');"
       "  function f(a,b) {"
       "    a = a | 0; b = b | 0;"
       "    return x[a] + y[b];"
       "  }"
       "  return f;"
       "})()";
   EmbeddedVector<char, 1024> source_buffer;
   SNPrintF(source_buffer, source, array_type, arraysize(kValues),
            values_buffer.start(), array_type, arraysize(kValues),
            values_buffer.start(), array_type, array_type);
@@ skipping 33 matching lines @@
   static const uint32_t kValues[] = {
       0x00000000, 0x00000001, 0x00000023, 0x00000042, 0x12345678, 0x87654321,
       0x0000003f, 0x0000007f, 0x00003fff, 0x00007fff, 0x3fffffff, 0x7fffffff,
       0x000000ff, 0x00000080, 0x0000ffff, 0x00008000, 0xffffffff, 0x80000000};
   EmbeddedVector<char, 1024> values_buffer;
   StringBuilder values_builder(values_buffer.start(), values_buffer.length());
   for (size_t i = 0; i < arraysize(kValues); ++i) {
     values_builder.AddFormatted("a[%d] = 0x%08x;", i, kValues[i]);
   }
 
-  // Note that below source creates two different typed arrays with distinct
-  // elements kind to get coverage for both access patterns:
-  // - IsFixedTypedArrayElementsKind(x)
-  // - IsExternalArrayElementsKind(y)
+  // Note that below source creates two different typed arrays with the same
+  // elements kind to get coverage for both (on heap/with external backing
+  // store) access patterns.
   const char* source =
       "(function(a) {"
       "  var x = (a = new %sArray(%d)); %s;"
       "  var y = (a = new %sArray(%d)); %s; %%TypedArrayGetBuffer(y);"
       "  if (!%%HasFixed%sElements(x)) %%AbortJS('x');"
-      "  if (!%%HasExternal%sElements(y)) %%AbortJS('y');"
+      "  if (!%%HasFixed%sElements(y)) %%AbortJS('y');"
       "  function f(a,b) {"
       "    a = a | 0; b = b | 0;"
       "    var t = x[a];"
       "    x[a] = y[b];"
       "    y[b] = t;"
       "    t = y[b];"
       "    y[b] = x[a];"
       "    x[a] = t;"
       "    return x[a] + y[b];"
       "  }"
@@ skipping 25 matching lines @@
   TypedArrayStoreHelper<int8_t>("Int8");
   TypedArrayStoreHelper<uint8_t>("Uint8");
   TypedArrayStoreHelper<int16_t>("Int16");
   TypedArrayStoreHelper<uint16_t>("Uint16");
   TypedArrayStoreHelper<int32_t>("Int32");
   TypedArrayStoreHelper<uint32_t>("Uint32");
   TypedArrayStoreHelper<float>("Float32");
   TypedArrayStoreHelper<double>("Float64");
   // TODO(mstarzinger): Add tests for ClampedUint8.
 }