Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: test/mjsunit/elements-kind.js

Issue 1262583002: Reland of "Remove ExternalArray, derived types, and element kinds" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/mjsunit/opt-elements-kind.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/elements-kind.js
diff --git a/test/mjsunit/elements-kind.js b/test/mjsunit/elements-kind.js
index cb2d178a7e3f0886e9a585cb0163ed5eac362d10..4da8a9dc60843cbaff12193c6db3766079c4ae83 100644
--- a/test/mjsunit/elements-kind.js
+++ b/test/mjsunit/elements-kind.js
@@ -32,15 +32,6 @@ var elements_kind = {
fast : 'fast elements',
fast_double : 'fast double elements',
dictionary : 'dictionary elements',
- external_int32 : 'external int8 elements',
- external_uint8 : 'external uint8 elements',
- external_int16 : 'external int16 elements',
- external_uint16 : 'external uint16 elements',
- external_int32 : 'external int32 elements',
- external_uint32 : 'external uint32 elements',
- external_float32 : 'external float32 elements',
- external_float64 : 'external float64 elements',
- external_uint8_clamped : 'external uint8_clamped elements',
fixed_int32 : 'fixed int8 elements',
fixed_uint8 : 'fixed uint8 elements',
fixed_int16 : 'fixed int16 elements',
@@ -58,34 +49,6 @@ function getKind(obj) {
if (%HasFastDoubleElements(obj)) return elements_kind.fast_double;
if (%HasDictionaryElements(obj)) return elements_kind.dictionary;
- // Every external kind is also an external array.
- if (%HasExternalInt8Elements(obj)) {
- return elements_kind.external_int8;
- }
- if (%HasExternalUint8Elements(obj)) {
- return elements_kind.external_uint8;
- }
- if (%HasExternalInt16Elements(obj)) {
- return elements_kind.external_int16;
- }
- if (%HasExternalUint16Elements(obj)) {
- return elements_kind.external_uint16;
- }
- if (%HasExternalInt32Elements(obj)) {
- return elements_kind.external_int32;
- }
- if (%HasExternalUint32Elements(obj)) {
- return elements_kind.external_uint32;
- }
- if (%HasExternalFloat32Elements(obj)) {
- return elements_kind.external_float32;
- }
- if (%HasExternalFloat64Elements(obj)) {
- return elements_kind.external_float64;
- }
- if (%HasExternalUint8ClampedElements(obj)) {
- return elements_kind.external_uint8_clamped;
- }
if (%HasFixedInt8Elements(obj)) {
return elements_kind.fixed_int8;
}
@@ -164,15 +127,15 @@ function test_wrapper() {
assertKind(elements_kind.fixed_uint8_clamped, new Uint8ClampedArray(512));
var ab = new ArrayBuffer(128);
- assertKind(elements_kind.external_int8, new Int8Array(ab));
- assertKind(elements_kind.external_uint8, new Uint8Array(ab));
- assertKind(elements_kind.external_int16, new Int16Array(ab));
- assertKind(elements_kind.external_uint16, new Uint16Array(ab));
- assertKind(elements_kind.external_int32, new Int32Array(ab));
- assertKind(elements_kind.external_uint32, new Uint32Array(ab));
- assertKind(elements_kind.external_float32, new Float32Array(ab));
- assertKind(elements_kind.external_float64, new Float64Array(ab));
- assertKind(elements_kind.external_uint8_clamped, new Uint8ClampedArray(ab));
+ assertKind(elements_kind.fixed_int8, new Int8Array(ab));
+ assertKind(elements_kind.fixed_uint8, new Uint8Array(ab));
+ assertKind(elements_kind.fixed_int16, new Int16Array(ab));
+ assertKind(elements_kind.fixed_uint16, new Uint16Array(ab));
+ assertKind(elements_kind.fixed_int32, new Int32Array(ab));
+ assertKind(elements_kind.fixed_uint32, new Uint32Array(ab));
+ assertKind(elements_kind.fixed_float32, new Float32Array(ab));
+ assertKind(elements_kind.fixed_float64, new Float64Array(ab));
+ assertKind(elements_kind.fixed_uint8_clamped, new Uint8ClampedArray(ab));
// Crankshaft support for smi-only array elements.
function monomorphic(array) {
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/mjsunit/opt-elements-kind.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698