Index: test/cctest/compiler/test-run-properties.cc |
diff --git a/test/cctest/compiler/test-run-properties.cc b/test/cctest/compiler/test-run-properties.cc |
index d4442f7a85d6ddfc6f295b3c9e8ba1e087bd350d..b7677f7fd207fbeafb2b3a7eb8690d2bc9bbf24d 100644 |
--- a/test/cctest/compiler/test-run-properties.cc |
+++ b/test/cctest/compiler/test-run-properties.cc |
@@ -21,16 +21,15 @@ static void TypedArrayLoadHelper(const char* array_type) { |
values_builder.AddFormatted("a[%d] = 0x%08x;", i, kValues[i]); |
} |
- // Note that below source creates two different typed arrays with distinct |
- // elements kind to get coverage for both access patterns: |
- // - IsFixedTypedArrayElementsKind(x) |
- // - IsExternalArrayElementsKind(y) |
+ // Note that below source creates two different typed arrays with the same |
+ // elements kind to get coverage for both (on heap / with external backing |
+ // store) access patterns. |
const char* source = |
"(function(a) {" |
" var x = (a = new %sArray(%d)); %s;" |
" var y = (a = new %sArray(%d)); %s; %%TypedArrayGetBuffer(y);" |
" if (!%%HasFixed%sElements(x)) %%AbortJS('x');" |
- " if (!%%HasExternal%sElements(y)) %%AbortJS('y');" |
+ " if (!%%HasFixed%sElements(y)) %%AbortJS('y');" |
" function f(a,b) {" |
" a = a | 0; b = b | 0;" |
" return x[a] + y[b];" |
@@ -84,16 +83,15 @@ static void TypedArrayStoreHelper(const char* array_type) { |
values_builder.AddFormatted("a[%d] = 0x%08x;", i, kValues[i]); |
} |
- // Note that below source creates two different typed arrays with distinct |
- // elements kind to get coverage for both access patterns: |
- // - IsFixedTypedArrayElementsKind(x) |
- // - IsExternalArrayElementsKind(y) |
+ // Note that below source creates two different typed arrays with the same |
+ // elements kind to get coverage for both (on heap/with external backing |
+ // store) access patterns. |
const char* source = |
"(function(a) {" |
" var x = (a = new %sArray(%d)); %s;" |
" var y = (a = new %sArray(%d)); %s; %%TypedArrayGetBuffer(y);" |
" if (!%%HasFixed%sElements(x)) %%AbortJS('x');" |
- " if (!%%HasExternal%sElements(y)) %%AbortJS('y');" |
+ " if (!%%HasFixed%sElements(y)) %%AbortJS('y');" |
" function f(a,b) {" |
" a = a | 0; b = b | 0;" |
" var t = x[a];" |