Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1262543003: ipc: Create an unforgeable mechanism to get the process id of the sender. (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Create an unforgeable mechanism to get the process id of the sender. ChannelReader now adds the process id of the sender to all external messages. BUG=513431 Committed: https://crrev.com/3c175a3dbe6f597c6011975d7488e5db8283760c Cr-Commit-Position: refs/heads/master@{#340798}

Patch Set 1 #

Patch Set 2 : Override method. #

Patch Set 3 : Fix compile errors. #

Patch Set 4 : Fix more windows compile errors without access to a windows machine. #

Patch Set 5 : Add a sender id to all external messages. #

Patch Set 6 : Remove log statements. #

Patch Set 7 : Remove dchecks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -18 lines) Patch
M ipc/attachment_broker_messages.h View 1 2 3 4 1 chunk +2 lines, -5 lines 0 comments Download
M ipc/attachment_broker_privileged_win.h View 1 chunk +1 line, -2 lines 0 comments Download
M ipc/attachment_broker_privileged_win.cc View 1 2 5 6 2 chunks +12 lines, -7 lines 0 comments Download
M ipc/attachment_broker_win.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ipc/ipc_channel_nacl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_channel_nacl.cc View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M ipc/ipc_channel_posix.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/ipc_channel_reader.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ipc/ipc_channel_reader.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/ipc_channel_reader_unittest.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/ipc_channel_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_channel_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/ipc_message.h View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M ipc/ipc_message.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1256993003 Patch 100001

Messages

Total messages: 26 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262543003/1
5 years, 4 months ago (2015-07-28 00:59:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262543003/20001
5 years, 4 months ago (2015-07-28 02:23:07 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262543003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262543003/40001
5 years, 4 months ago (2015-07-28 02:28:21 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/85222)
5 years, 4 months ago (2015-07-28 03:10:46 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262543003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262543003/60001
5 years, 4 months ago (2015-07-28 16:11:29 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262543003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262543003/100001
5 years, 4 months ago (2015-07-28 17:52:28 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/83643) linux_chromium_rel_ng on ...
5 years, 4 months ago (2015-07-28 18:40:05 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262543003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262543003/120001
5 years, 4 months ago (2015-07-28 19:43:45 UTC) #17
erikchen
tsepez: Please review. I wasn't a huge fan of this implementation, but the alternatives I ...
5 years, 4 months ago (2015-07-28 20:44:25 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-28 20:56:03 UTC) #21
Tom Sepez
lgtm
5 years, 4 months ago (2015-07-28 23:03:49 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262543003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262543003/120001
5 years, 4 months ago (2015-07-28 23:11:43 UTC) #24
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 4 months ago (2015-07-28 23:16:55 UTC) #25
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 23:17:27 UTC) #26
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/3c175a3dbe6f597c6011975d7488e5db8283760c
Cr-Commit-Position: refs/heads/master@{#340798}

Powered by Google App Engine
This is Rietveld 408576698