Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1256993003: ipc: Create AttachmentBrokerPrivileged and AttachmentBrokerUnprivileged. (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@add_ipc_message_feature
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Create AttachmentBrokerPrivileged and AttachmentBrokerUnprivileged. This CL is a refactor and contains no behavior changes. AttachmentBroker is an abstract base class. I made two new abstract subclasses, AttachmentBrokerPrivileged and AttachmentBrokerUnprivileged for use in privileged and unprivileged processes respectively. These in turn are inherited by AttachmentBrokerPrivilegedWin and AttachmentBrokerUnprivilegedWin. BUG=493414 TBR=avi@chromium.org Committed: https://crrev.com/484c0084e981f9bb1e43757ae2686dd4e8c6205d Cr-Commit-Position: refs/heads/master@{#340803}

Patch Set 1 #

Patch Set 2 : Remove unused forward declaration. #

Patch Set 3 : More refactor. #

Patch Set 4 : #

Patch Set 5 : Compile errors. #

Patch Set 6 : Rebase. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -256 lines) Patch
M content/child/child_thread_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/child_process_host_impl.cc View 1 2 1 chunk +3 lines, -3 lines 1 comment Download
M ipc/BUILD.gn View 1 2 3 4 2 chunks +7 lines, -3 lines 0 comments Download
M ipc/attachment_broker.h View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
A ipc/attachment_broker_privileged.h View 1 2 3 4 1 chunk +44 lines, -0 lines 0 comments Download
A ipc/attachment_broker_privileged.cc View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
M ipc/attachment_broker_privileged_win.h View 3 chunks +5 lines, -18 lines 0 comments Download
M ipc/attachment_broker_privileged_win.cc View 1 2 3 4 5 3 chunks +4 lines, -19 lines 0 comments Download
M ipc/attachment_broker_privileged_win_unittest.cc View 1 2 4 chunks +9 lines, -7 lines 0 comments Download
A ipc/attachment_broker_unprivileged.h View 1 2 3 4 1 chunk +36 lines, -0 lines 0 comments Download
A + ipc/attachment_broker_unprivileged.cc View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
A + ipc/attachment_broker_unprivileged_win.h View 2 chunks +10 lines, -20 lines 0 comments Download
A + ipc/attachment_broker_unprivileged_win.cc View 1 2 3 4 4 chunks +9 lines, -10 lines 0 comments Download
A + ipc/attachment_broker_unprivileged_win_unittest.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
D ipc/attachment_broker_win.h View 1 chunk +0 lines, -51 lines 0 comments Download
D ipc/attachment_broker_win.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D ipc/attachment_broker_win_unittest.cc View 1 2 1 chunk +0 lines, -51 lines 0 comments Download
M ipc/ipc.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc.gypi View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1262543003 Patch 120001

Dependent Patchsets:

Issue 1260053003 Patch 1
Issue 1260053003 Patch 20001

Messages

Total messages: 25 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256993003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256993003/20001
5 years, 4 months ago (2015-07-28 16:33:38 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256993003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256993003/60001
5 years, 4 months ago (2015-07-28 17:15:21 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/63979)
5 years, 4 months ago (2015-07-28 17:51:20 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256993003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256993003/80001
5 years, 4 months ago (2015-07-28 18:16:50 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/83658) linux_chromium_rel_ng on ...
5 years, 4 months ago (2015-07-28 19:04:04 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256993003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256993003/100001
5 years, 4 months ago (2015-07-28 19:50:51 UTC) #14
erikchen
tsepez: Please review.
5 years, 4 months ago (2015-07-28 20:53:41 UTC) #16
erikchen
https://codereview.chromium.org/1256993003/diff/100001/content/common/child_process_host_impl.cc File content/common/child_process_host_impl.cc (right): https://codereview.chromium.org/1256993003/diff/100001/content/common/child_process_host_impl.cc#newcode38 content/common/child_process_host_impl.cc:38: base::LazyInstance<IPC::AttachmentBrokerPrivilegedWin>::Leaky I snuck in this change, replacing AttachmentBrokerWin with ...
5 years, 4 months ago (2015-07-28 20:55:56 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-28 21:19:14 UTC) #19
Tom Sepez
lgtm
5 years, 4 months ago (2015-07-28 23:07:53 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256993003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256993003/100001
5 years, 4 months ago (2015-07-28 23:19:11 UTC) #23
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 4 months ago (2015-07-28 23:25:54 UTC) #24
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 23:26:46 UTC) #25
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/484c0084e981f9bb1e43757ae2686dd4e8c6205d
Cr-Commit-Position: refs/heads/master@{#340803}

Powered by Google App Engine
This is Rietveld 408576698