ipc/attachment_broker_messages.h - Issue 1262543003: ipc: Create an unforgeable mechanism to get the process id of the sender.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/attachment_broker_messages.h

Issue 1262543003: ipc: Create an unforgeable mechanism to get the process id of the sender. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove dchecks. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/attachment_broker_messages.h

diff --git a/ipc/attachment_broker_messages.h b/ipc/attachment_broker_messages.h

index 71b89864b06e83784df6b25000ce38c10fdb1b18..066e19c986a9f99547356315b865b4f1ac239c78 100644

--- a/ipc/attachment_broker_messages.h

+++ b/ipc/attachment_broker_messages.h

@@ -51,10 +51,7 @@ IPC_MESSAGE_CONTROL1(

// Sent from a non-broker to a broker to request the duplication of a HANDLE

// into a different process (possibly the broker process, or even the original

// process).

-// TODO(erikchen): https://code.google.com/p/chromium/issues/detail?id=513431

-// *sender_pid* should be unforgeably generated by the receiving channel.

-IPC_MESSAGE_CONTROL2(

+IPC_MESSAGE_CONTROL1(

AttachmentBrokerMsg_DuplicateWinHandle,

- IPC::internal::HandleAttachmentWin::WireFormat /* wire_format */,

- base::ProcessId /* sender_pid */)

+ IPC::internal::HandleAttachmentWin::WireFormat /* wire_format */)

#endif // defined(OS_WIN)

« no previous file with comments | « no previous file | ipc/attachment_broker_privileged_win.h » ('j') | no next file with comments »