Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: ipc/attachment_broker_win.cc

Issue 1262543003: ipc: Create an unforgeable mechanism to get the process id of the sender. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove dchecks. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/attachment_broker_privileged_win.cc ('k') | ipc/ipc_channel_nacl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/attachment_broker_win.cc
diff --git a/ipc/attachment_broker_win.cc b/ipc/attachment_broker_win.cc
index a4cb067afa69c170afea18bdd1034ac17f551d63..1bc013dd03048a334838ba2f0f9271d12e7c95b8 100644
--- a/ipc/attachment_broker_win.cc
+++ b/ipc/attachment_broker_win.cc
@@ -27,10 +27,7 @@ bool AttachmentBrokerWin::SendAttachmentToProcess(
static_cast<const internal::HandleAttachmentWin*>(attachment);
internal::HandleAttachmentWin::WireFormat format =
handle_attachment->GetWireFormat(destination_process);
- // TODO(erikchen): Replace the call to base::Process::Current().Pid() with
- // a non-forgeable mechanism. http://crbug.com/513431.
- return sender_->Send(new AttachmentBrokerMsg_DuplicateWinHandle(
- format, base::Process::Current().Pid()));
+ return sender_->Send(new AttachmentBrokerMsg_DuplicateWinHandle(format));
}
return false;
}
« no previous file with comments | « ipc/attachment_broker_privileged_win.cc ('k') | ipc/ipc_channel_nacl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698