Straightens outs DEPS in mojo/common

Straightens outs DEPS in mojo/common

Prior to this change //mojo/environment depended upon //mojo/common. //mojo/common's deps are wrong and it needs to be depend upon various things in //third_party/mojo/src/mojo... When these DEPS are added link errors result because Environment and and a couple of other things need to be defined. These are defined in //mojo/environment. But //mojo/environment can't be a dep of //mojo/common, else we get a cycle.

To straighten this out I've moved the files //mojo/environment needs from //mojo/common to //mojo/message_pump. //mojo/environment no longer depends upon //mojo/common, only //mojo/message_pump. //mojo/common can then depend upon //mojo/environment and we no longer have the cycle. Yay!

BUG=none
TEST=none

Committed: https://crrev.com/a11b4d76a27816fe025af647825becac5f633c34
Cr-Commit-Position: refs/heads/master@{#341979}

Committed: https://crrev.com/add030b55dee834423004bde2a0d92afd8a7be7e
Cr-Commit-Position: refs/heads/master@{#342252}

[sky, 2015-08-05 02:02:35]

sky@chromium.org changed reviewers:
+ jam@chromium.org

[jam, 2015-08-05 15:38:44]

lgtm

https://codereview.chromium.org/1262173005/diff/60001/mojo/common/BUILD.gn
File mojo/common/BUILD.gn (right):

https://codereview.chromium.org/1262173005/diff/60001/mojo/common/BUILD.gn#ne...
mojo/common/BUILD.gn:89: "../message_pump/message_pump_mojo_unittest.cc",
i understand why you're doing this (a pita to create another target and then
also both will be tiny...) still a bit weird to see this :) maybe call it out
the justification in a comment?

[sky, 2015-08-05 16:07:31]

https://codereview.chromium.org/1262173005/diff/60001/mojo/common/BUILD.gn
File mojo/common/BUILD.gn (right):

https://codereview.chromium.org/1262173005/diff/60001/mojo/common/BUILD.gn#ne...
mojo/common/BUILD.gn:89: "../message_pump/message_pump_mojo_unittest.cc",
On 2015/08/05 15:38:44, jam wrote:
> i understand why you're doing this (a pita to create another target and then
> also both will be tiny...) still a bit weird to see this :) maybe call it out
> the justification in a comment?

Done.

[sky, 2015-08-05 16:07:50]

The CQ bit was checked by sky@chromium.org

[sky, 2015-08-05 16:07:50]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1262173005/#ps80001
(title: "comment")

[commit-bot: I haz the power, 2015-08-05 16:08:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1262173005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1262173005/80001

[commit-bot: I haz the power, 2015-08-05 18:06:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-05 18:06:51]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sky, 2015-08-05 18:07:29]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2015-08-05 18:08:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1262173005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1262173005/80001

[commit-bot: I haz the power, 2015-08-05 19:19:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-05 19:19:57]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sky, 2015-08-05 19:22:23]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2015-08-05 19:22:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1262173005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1262173005/80001

[commit-bot: I haz the power, 2015-08-05 21:29:42]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-05 21:30:29]

Patchset 5 (id:??) landed as
https://crrev.com/a11b4d76a27816fe025af647825becac5f633c34
Cr-Commit-Position: refs/heads/master@{#341979}

[sky, 2015-08-05 23:52:12]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1280463003/ by sky@chromium.org.

The reason for reverting is: Broke MediaRouterMojoImplTest.QueuedWhileAsleep on
linux debug..

[sky, 2015-08-06 21:03:09]

This was reverted because it broke some media unit_tests. I believe the failure
was because I made //mojo/message_pump a static library. This mean the unit
tests ended up with one copy of the code, and //mojo/environment another.
Because the code in //mojo/message_pump does things based on MessagePump type
the different compile units broke the test.

I've changed //mojo/message_pump to be a shared library and thing seem good.

Diff between patchset 6 and latest to see set of changes.

Take another look?

[jam, 2015-08-06 21:05:38]

lgtm

[sky, 2015-08-06 21:06:06]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2015-08-06 21:07:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1262173005/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1262173005/160001

[commit-bot: I haz the power, 2015-08-06 22:40:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-06 22:40:17]

Try jobs failed on following builders:
  mac_chromium_10.10_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_10.1...)

[sky, 2015-08-06 22:41:00]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2015-08-06 22:42:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1262173005/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1262173005/160001

[commit-bot: I haz the power, 2015-08-07 01:06:27]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-08-07 01:07:47]

Patchset 9 (id:??) landed as
https://crrev.com/add030b55dee834423004bde2a0d92afd8a7be7e
Cr-Commit-Position: refs/heads/master@{#342252}