Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: mojo/common/BUILD.gn

Issue 1262173005: Straightens outs DEPS in mojo/common (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add dep on system_for_component Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/application/public/cpp/lib/content_handler_factory.cc ('k') | mojo/common/handle_watcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/common/BUILD.gn
diff --git a/mojo/common/BUILD.gn b/mojo/common/BUILD.gn
index 99f0ba52632b4bc90c05e7dfb8b4022b77e4df08..6dfed2fd3562afbbb9cf17f3cd6021615d77b613 100644
--- a/mojo/common/BUILD.gn
+++ b/mojo/common/BUILD.gn
@@ -21,13 +21,6 @@ component("common_base") {
"data_pipe_file_utils.cc",
"data_pipe_utils.cc",
"data_pipe_utils.h",
- "handle_watcher.cc",
- "handle_watcher.h",
- "message_pump_mojo.cc",
- "message_pump_mojo.h",
- "message_pump_mojo_handler.h",
- "time_helper.cc",
- "time_helper.h",
"user_agent.cc",
"user_agent.h",
"weak_binding_set.h",
@@ -39,7 +32,11 @@ component("common_base") {
deps = [
"//base",
"//base/third_party/dynamic_annotations",
+ "//mojo/environment:chromium",
"//third_party/mojo/src/mojo/public/c/system:for_component",
+ "//third_party/mojo/src/mojo/public/cpp/bindings",
+ "//third_party/mojo/src/mojo/public/cpp/environment",
+ "//third_party/mojo/src/mojo/public/cpp/system",
]
}
@@ -78,6 +75,7 @@ test("mojo_common_unittests") {
"//base:message_loop_tests",
"//base/test:test_support",
"//mojo/environment:chromium",
+ "//mojo/message_pump",
"//testing/gtest",
"//third_party/mojo/src/mojo/edk/test:run_all_unittests",
"//third_party/mojo/src/mojo/edk/test:test_support",
@@ -87,9 +85,11 @@ test("mojo_common_unittests") {
]
sources = [
+ # The message_pump tests are so small and some what related to this code
+ # that we put them here.
+ "../message_pump/handle_watcher_unittest.cc",
+ "../message_pump/message_pump_mojo_unittest.cc",
"common_type_converters_unittest.cc",
- "handle_watcher_unittest.cc",
- "message_pump_mojo_unittest.cc",
]
}
« no previous file with comments | « mojo/application/public/cpp/lib/content_handler_factory.cc ('k') | mojo/common/handle_watcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698