Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: mojo/mojo_base.gyp

Issue 1262173005: Straightens outs DEPS in mojo/common (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add dep on system_for_component Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/message_pump/time_helper.cc ('k') | mojo/runner/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/mojo_base.gyp
diff --git a/mojo/mojo_base.gyp b/mojo/mojo_base.gyp
index 550c41d55043c861ad72b8064c0f411ea246518d..6b1d251fd468d330f45f6f6ecdad43e2f07b7758 100644
--- a/mojo/mojo_base.gyp
+++ b/mojo/mojo_base.gyp
@@ -36,6 +36,31 @@
'type': 'none',
},
{
+ # GN version: //mojo/message_pump
+ 'target_name': 'mojo_message_pump_lib',
+ 'type': '<(component)',
+ 'defines': [
+ 'MOJO_MESSAGE_PUMP_IMPLEMENTATION',
+ ],
+ 'dependencies': [
+ '../base/base.gyp:base',
+ '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
+ '<(mojo_system_for_component)',
+ ],
+ 'export_dependent_settings': [
+ '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
+ ],
+ 'sources': [
+ 'message_pump/handle_watcher.cc',
+ 'message_pump/handle_watcher.h',
+ 'message_pump/message_pump_mojo.cc',
+ 'message_pump/message_pump_mojo.h',
+ 'message_pump/message_pump_mojo_handler.h',
+ 'message_pump/time_helper.cc',
+ 'message_pump/time_helper.h',
+ ],
+ },
+ {
# GN version: //mojo/common
'target_name': 'mojo_common_lib',
'type': '<(component)',
@@ -56,13 +81,6 @@
'common/data_pipe_file_utils.cc',
'common/data_pipe_utils.cc',
'common/data_pipe_utils.h',
- 'common/handle_watcher.cc',
- 'common/handle_watcher.h',
- 'common/message_pump_mojo.cc',
- 'common/message_pump_mojo.h',
- 'common/message_pump_mojo_handler.h',
- 'common/time_helper.cc',
- 'common/time_helper.h',
],
},
{
@@ -112,19 +130,20 @@
'../base/base.gyp:base_message_loop_tests',
'../testing/gtest.gyp:gtest',
'../url/url.gyp:url_lib',
- 'mojo_common_lib',
- 'mojo_url_type_converters',
'../third_party/mojo/mojo_edk.gyp:mojo_system_impl',
'../third_party/mojo/mojo_edk.gyp:mojo_common_test_support',
'../third_party/mojo/mojo_edk.gyp:mojo_run_all_unittests',
- 'mojo_environment_chromium',
'../third_party/mojo/mojo_public.gyp:mojo_cpp_bindings',
'../third_party/mojo/mojo_public.gyp:mojo_public_test_utils',
+ 'mojo_common_lib',
+ 'mojo_environment_chromium',
+ 'mojo_message_pump_lib',
+ 'mojo_url_type_converters',
],
'sources': [
'common/common_type_converters_unittest.cc',
- 'common/handle_watcher_unittest.cc',
- 'common/message_pump_mojo_unittest.cc',
+ 'message_pump/handle_watcher_unittest.cc',
+ 'message_pump/message_pump_mojo_unittest.cc',
],
},
{
@@ -136,7 +155,6 @@
'../third_party/mojo/mojo_public.gyp:mojo_cpp_bindings',
],
'sources': [
- 'environment/environment.cc',
# TODO(vtl): This is kind of ugly. (See TODO in logging.h.)
"../third_party/mojo/src/mojo/public/cpp/environment/async_waiter.h",
"../third_party/mojo/src/mojo/public/cpp/environment/lib/async_waiter.cc",
@@ -145,6 +163,7 @@
"../third_party/mojo/src/mojo/public/cpp/environment/lib/scoped_task_tracking.cc",
"../third_party/mojo/src/mojo/public/cpp/environment/logging.h",
"../third_party/mojo/src/mojo/public/cpp/environment/task_tracker.h",
+ 'environment/environment.cc',
],
'include_dirs': [
'..',
@@ -169,7 +188,7 @@
'dependencies': [
'../base/base.gyp:base',
'../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
- 'mojo_common_lib',
+ 'mojo_message_pump_lib',
'<(mojo_system_for_component)',
],
'sources': [
@@ -240,7 +259,7 @@
],
'dependencies': [
'mojo_application_bindings',
- 'mojo_common_lib',
+ 'mojo_message_pump_lib',
],
},
{
« no previous file with comments | « mojo/message_pump/time_helper.cc ('k') | mojo/runner/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698