Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1261243002: Merge 199493 "Revert of Enable ServiceWorkerPerformanceTimeline ..." (Closed)

Created:
5 years, 4 months ago by Kunihiko Sakamoto
Modified:
5 years, 4 months ago
Reviewers:
Kunihiko Sakamoto
CC:
blink-reviews
Visibility:
Public.

Description

Merge 199493 "Revert of Enable ServiceWorkerPerformanceTimeline ..." > Revert of Enable ServiceWorkerPerformanceTimeline flag for stable (patchset #1 id:1 of https://codereview.chromium.org/1203953002/) > > Reason for revert: > This shipped new prefixed APIs: > https://groups.google.com/a/chromium.org/d/msg/blink-dev/htsW078UcFA/2cel1auAH60J > > Original issue's description: > > Enable ServiceWorkerPerformanceTimeline flag for stable > > > > This ships User Timing and Resource Timing in Workers, and workerStart > > attribute of Resource Timing. > > > > I think it's safe to enable it now; User Timing and workerStart have > > landed over 2 weeks ago. Resource Timing part is new, but I only added > > main thread to worker plumbing on the existing stable implementation. > > > > Intent to Implement and Ship: > > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/htsW078UcFA > > > > BUG=465640, 465641, 465643 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197722 > > BUG=465640, 465641, 465643 > > Review URL: https://codereview.chromium.org/1254803002 TBR=ksakamoto@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kunihiko Sakamoto
5 years, 4 months ago (2015-07-29 01:44:04 UTC) #1
Kunihiko Sakamoto
5 years, 4 months ago (2015-07-29 01:44:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r199619.

Powered by Google App Engine
This is Rietveld 408576698