Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1203953002: Enable ServiceWorkerPerformanceTimeline flag for stable (Closed)

Created:
5 years, 6 months ago by Kunihiko Sakamoto
Modified:
5 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Enable ServiceWorkerPerformanceTimeline flag for stable This ships User Timing and Resource Timing in Workers, and workerStart attribute of Resource Timing. I think it's safe to enable it now; User Timing and workerStart have landed over 2 weeks ago. Resource Timing part is new, but I only added main thread to worker plumbing on the existing stable implementation. Intent to Implement and Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/htsW078UcFA BUG=465640, 465641, 465643 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197722

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Kunihiko Sakamoto
5 years, 6 months ago (2015-06-24 07:17:54 UTC) #2
tkent
We usually don't enable a feature just before a branch point. Do you think it's ...
5 years, 6 months ago (2015-06-24 07:21:18 UTC) #3
Kunihiko Sakamoto
On 2015/06/24 07:21:18, tkent wrote: > We usually don't enable a feature just before a ...
5 years, 6 months ago (2015-06-24 07:55:40 UTC) #4
tkent
lgtm
5 years, 6 months ago (2015-06-24 07:57:48 UTC) #5
Kunihiko Sakamoto
Thanks!
5 years, 6 months ago (2015-06-24 08:00:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203953002/1
5 years, 6 months ago (2015-06-24 08:01:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197722
5 years, 6 months ago (2015-06-24 09:34:45 UTC) #9
philipj_slow
5 years, 5 months ago (2015-07-24 06:50:58 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1255813002/ by philipj@opera.com.

The reason for reverting is: This shipped new prefixed APIs:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/htsW078UcFA/2cel1auA....

Powered by Google App Engine
This is Rietveld 408576698