Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1254803002: Revert of Enable ServiceWorkerPerformanceTimeline flag for stable (Closed)

Created:
5 years, 5 months ago by Kunihiko Sakamoto
Modified:
5 years, 3 months ago
Reviewers:
tkent, philipj_slow
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Enable ServiceWorkerPerformanceTimeline flag for stable (patchset #1 id:1 of https://codereview.chromium.org/1203953002/) Reason for revert: This shipped new prefixed APIs: https://groups.google.com/a/chromium.org/d/msg/blink-dev/htsW078UcFA/2cel1auAH60J Original issue's description: > Enable ServiceWorkerPerformanceTimeline flag for stable > > This ships User Timing and Resource Timing in Workers, and workerStart > attribute of Resource Timing. > > I think it's safe to enable it now; User Timing and workerStart have > landed over 2 weeks ago. Resource Timing part is new, but I only added > main thread to worker plumbing on the existing stable implementation. > > Intent to Implement and Ship: > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/htsW078UcFA > > BUG=465640, 465641, 465643 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197722 BUG=465640, 465641, 465643 Committed: https://crrev.com/94212593f88dbdb92ea8f090b28cc9a5c4a2c8e3 git-svn-id: svn://svn.chromium.org/blink/trunk@199493 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Fix webexposed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254803002/1
5 years, 5 months ago (2015-07-24 10:16:08 UTC) #2
Kunihiko Sakamoto
This is going to be merged to M45 to avoid shipping prefixed APIs. We're re-aiming ...
5 years, 5 months ago (2015-07-24 10:24:18 UTC) #4
philipj_slow
lgtm
5 years, 5 months ago (2015-07-24 11:08:14 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/71486)
5 years, 5 months ago (2015-07-24 11:35:05 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254803002/1
5 years, 4 months ago (2015-07-27 01:15:12 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254803002/20001
5 years, 4 months ago (2015-07-27 03:46:55 UTC) #11
Kunihiko Sakamoto
Kent-san, PTAL
5 years, 4 months ago (2015-07-27 06:01:19 UTC) #12
tkent
lgtm
5 years, 4 months ago (2015-07-27 06:04:42 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-27 07:01:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254803002/20001
5 years, 4 months ago (2015-07-27 07:16:10 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199493
5 years, 4 months ago (2015-07-27 07:19:50 UTC) #19
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:47:57 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/94212593f88dbdb92ea8f090b28cc9a5c4a2c8e3

Powered by Google App Engine
This is Rietveld 408576698