Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1261073003: Tolerate GetRoot() returning null. (Closed)

Created:
5 years, 4 months ago by dmazzoni
Modified:
5 years, 4 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tolerate GetRoot() returning null. When inside one of the AXTreeDelegate callbacks, GetRoot() might return null, we need to handle that case. BUG=514609 Committed: https://crrev.com/2341b80efe0de0590dc9f8ee5ef8cfdcd108ceaf Cr-Commit-Position: refs/heads/master@{#340773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M content/browser/accessibility/browser_accessibility_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1200133002 Patch 1

Messages

Total messages: 9 (3 generated)
dmazzoni
5 years, 4 months ago (2015-07-28 17:39:11 UTC) #2
dmazzoni
5 years, 4 months ago (2015-07-28 17:39:29 UTC) #4
David Tseng
lgtm
5 years, 4 months ago (2015-07-28 21:41:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261073003/1
5 years, 4 months ago (2015-07-28 21:42:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 21:48:56 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 21:49:44 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2341b80efe0de0590dc9f8ee5ef8cfdcd108ceaf
Cr-Commit-Position: refs/heads/master@{#340773}

Powered by Google App Engine
This is Rietveld 408576698