content/browser/accessibility/browser_accessibility_manager_android.cc - Issue 1261073003: Tolerate GetRoot() returning null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.cc

Issue 1261073003: Tolerate GetRoot() returning null. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager.cc ('k') | content/browser/accessibility/browser_accessibility_manager_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc

index 703d800a204d678dc28fd36c75775484267d8ea4..3cab6ea3665f15731ad7605ef5e890b26972f093 100644

--- a/content/browser/accessibility/browser_accessibility_manager_android.cc

+++ b/content/browser/accessibility/browser_accessibility_manager_android.cc

@@ -192,7 +192,10 @@ void BrowserAccessibilityManagerAndroid::NotifyAccessibilityEvent(

}

jint BrowserAccessibilityManagerAndroid::GetRootId(JNIEnv* env, jobject obj) {

- return static_cast<jint>(GetRoot()->GetId());

+ if (GetRoot())

+ return static_cast<jint>(GetRoot()->GetId());

+ else

+ return -1;

}

jboolean BrowserAccessibilityManagerAndroid::IsNodeValid(