content/browser/accessibility/browser_accessibility_manager_mac.mm - Issue 1261073003: Tolerate GetRoot() returning null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_mac.mm

Issue 1261073003: Tolerate GetRoot() returning null. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/browser_accessibility_manager_mac.mm

diff --git a/content/browser/accessibility/browser_accessibility_manager_mac.mm b/content/browser/accessibility/browser_accessibility_manager_mac.mm

index d4c1485d89939c9455921eb754e0c89eb6fc0492..9f6213d1efa474ae0561e0557dfde679c4c11abd 100644

--- a/content/browser/accessibility/browser_accessibility_manager_mac.mm

+++ b/content/browser/accessibility/browser_accessibility_manager_mac.mm

@@ -188,8 +188,10 @@ void BrowserAccessibilityManagerMac::OnAtomicUpdateFinished(

// internal state and find newly-added live regions this time.

BrowserAccessibilityMac* root =

static_cast<BrowserAccessibilityMac*>(GetRoot());

- root->RecreateNativeObject();

- NotifyAccessibilityEvent(ui::AX_EVENT_CHILDREN_CHANGED, root);

+ if (root) {

+ root->RecreateNativeObject();

+ NotifyAccessibilityEvent(ui::AX_EVENT_CHILDREN_CHANGED, root);

+ }

}

} // namespace content