content/browser/accessibility/browser_accessibility_manager.cc - Issue 1261073003: Tolerate GetRoot() returning null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager.cc

Issue 1261073003: Tolerate GetRoot() returning null. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/browser_accessibility_manager.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager.cc b/content/browser/accessibility/browser_accessibility_manager.cc

index 6aaf25575c926e45dda8026e5b6519a93dbd7bb0..9a42dc169e7e897158a10536b0199d580b9c56f4 100644

--- a/content/browser/accessibility/browser_accessibility_manager.cc

+++ b/content/browser/accessibility/browser_accessibility_manager.cc

@@ -129,7 +129,9 @@ ui::AXTreeUpdate BrowserAccessibilityManager::GetEmptyDocument() {

}

BrowserAccessibility* BrowserAccessibilityManager::GetRoot() {

- return GetFromAXNode(tree_->root());

+ // tree_->root() can be null during AXTreeDelegate callbacks.

+ ui::AXNode* root = tree_->root();

+ return root ? GetFromAXNode(root) : nullptr;

}

BrowserAccessibility* BrowserAccessibilityManager::GetFromAXNode(

« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility_manager_android.cc » ('j') | no next file with comments »