Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 126093010: Use ContextProvider subclass to provide WGC3D pointers (Closed)

Created:
6 years, 11 months ago by jamesr
Modified:
6 years, 11 months ago
Reviewers:
no sievers, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Use ContextProvider subclass to provide WGC3D pointers Some cc::ContextProvider instances will also need to provide WebGraphicsContext3D* interfaces to the underlying GL context, but not all. This adds a subclass of ContextProvider in content:: to use for these users. The compositor itself doesn't need the WGC3D accessor so it just uses the base class. BUG=181120 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244383 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244697

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Move ContextProviderWebContext to webkit/common/gpu and make webkit::gpu::ContextProviderInProcess … #

Patch Set 6 : type tighten GetOffscreenContextProviderForCompositorThread #

Patch Set 7 : #

Patch Set 8 : fix non exported base warning on windows #

Patch Set 9 : Use proper provider type in RenderViewImpl::CreateAndroidWebMediaPlayer #

Patch Set 10 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -109 lines) Patch
M content/browser/android/in_process/synchronous_compositor_factory_impl.h View 1 2 3 4 5 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.h View 1 2 3 4 5 6 7 3 chunks +6 lines, -2 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 1 2 3 4 5 6 7 8 9 2 chunks +11 lines, -6 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/android/synchronous_compositor_factory.h View 1 2 3 4 5 2 chunks +7 lines, -1 line 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 3 4 3 chunks +4 lines, -3 lines 0 comments Download
A + content/renderer/webgraphicscontext3d_provider_impl.h View 1 2 3 4 2 chunks +13 lines, -11 lines 0 comments Download
A + content/renderer/webgraphicscontext3d_provider_impl.cc View 1 2 3 4 1 chunk +6 lines, -8 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.h View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.cc View 1 2 3 4 5 6 7 8 9 1 chunk +7 lines, -0 lines 0 comments Download
A webkit/common/gpu/context_provider_web_context.h View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
D webkit/common/gpu/webgraphicscontext3d_provider_impl.h View 1 2 3 1 chunk +0 lines, -36 lines 0 comments Download
D webkit/common/gpu/webgraphicscontext3d_provider_impl.cc View 1 2 3 1 chunk +0 lines, -27 lines 0 comments Download
M webkit/common/gpu/webkit_gpu.gyp View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 33 (0 generated)
jamesr
This pushes the WebGraphicsContext3D* getters up from cc/ into content, although this patch doesn't actually ...
6 years, 11 months ago (2014-01-07 21:44:24 UTC) #1
piman
LGTM+nits https://codereview.chromium.org/126093010/diff/50001/content/common/gpu/client/context_provider_command_buffer.h File content/common/gpu/client/context_provider_command_buffer.h (right): https://codereview.chromium.org/126093010/diff/50001/content/common/gpu/client/context_provider_command_buffer.h#newcode43 content/common/gpu/client/context_provider_command_buffer.h:43: virtual blink::WebGraphicsContext3D* WebContext3D() OVERRIDE; nit: you can return ...
6 years, 11 months ago (2014-01-08 01:22:50 UTC) #2
jamesr
Will cq once the prerequisites are safely landed. https://codereview.chromium.org/126093010/diff/50001/content/common/gpu/client/context_provider_command_buffer.h File content/common/gpu/client/context_provider_command_buffer.h (right): https://codereview.chromium.org/126093010/diff/50001/content/common/gpu/client/context_provider_command_buffer.h#newcode43 content/common/gpu/client/context_provider_command_buffer.h:43: virtual ...
6 years, 11 months ago (2014-01-08 02:20:14 UTC) #3
piman
https://codereview.chromium.org/126093010/diff/50001/content/common/gpu/client/context_provider_web_context.h File content/common/gpu/client/context_provider_web_context.h (right): https://codereview.chromium.org/126093010/diff/50001/content/common/gpu/client/context_provider_web_context.h#newcode19 content/common/gpu/client/context_provider_web_context.h:19: friend class RefCountedThreadSafe<ContextProviderWebContext>; On 2014/01/08 02:20:15, jamesr wrote: > ...
6 years, 11 months ago (2014-01-08 02:26:40 UTC) #4
jamesr
The android trybots revealed an issue that ps5 tries to fix. The issue is android's ...
6 years, 11 months ago (2014-01-08 23:10:45 UTC) #5
piman
LGTM, the android-specific changes seem harmless enough.
6 years, 11 months ago (2014-01-08 23:14:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/126093010/180001
6 years, 11 months ago (2014-01-08 23:18:25 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=211675
6 years, 11 months ago (2014-01-09 01:12:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/126093010/180001
6 years, 11 months ago (2014-01-09 01:51:56 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=66108
6 years, 11 months ago (2014-01-09 03:58:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/126093010/180001
6 years, 11 months ago (2014-01-09 04:48:54 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=66141
6 years, 11 months ago (2014-01-09 07:04:02 UTC) #12
no sievers
lgtm, but does GetOffscreenContextProviderForCompositorThread() actually have to return a ContextProviderWebContext rather than just a ContextProvider?
6 years, 11 months ago (2014-01-09 13:55:58 UTC) #13
jamesr
On 2014/01/09 13:55:58, sievers wrote: > lgtm, but does GetOffscreenContextProviderForCompositorThread() actually have to > return ...
6 years, 11 months ago (2014-01-09 19:18:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/126093010/730001
6 years, 11 months ago (2014-01-09 20:44:08 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=244341
6 years, 11 months ago (2014-01-09 22:46:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/126093010/730001
6 years, 11 months ago (2014-01-10 01:06:13 UTC) #17
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=111450
6 years, 11 months ago (2014-01-10 03:21:55 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/126093010/730001
6 years, 11 months ago (2014-01-10 06:23:00 UTC) #19
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=190163
6 years, 11 months ago (2014-01-10 08:35:25 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/126093010/1280001
6 years, 11 months ago (2014-01-10 20:19:01 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/126093010/1280001
6 years, 11 months ago (2014-01-10 23:14:49 UTC) #22
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=66809
6 years, 11 months ago (2014-01-11 03:10:38 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/126093010/1650001
6 years, 11 months ago (2014-01-11 03:13:37 UTC) #24
commit-bot: I haz the power
Change committed as 244383
6 years, 11 months ago (2014-01-11 23:08:54 UTC) #25
jamesr
The webgl conformance suite on android discovered a null ptr deref, so this patch was ...
6 years, 11 months ago (2014-01-13 20:57:24 UTC) #26
piman
lgtm
6 years, 11 months ago (2014-01-13 21:08:26 UTC) #27
no sievers
On 2014/01/13 20:57:24, jamesr wrote: > The webgl conformance suite on android discovered a null ...
6 years, 11 months ago (2014-01-13 21:15:38 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/126093010/1890001
6 years, 11 months ago (2014-01-13 21:30:25 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/126093010/1890001
6 years, 11 months ago (2014-01-13 23:24:28 UTC) #30
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=245881
6 years, 11 months ago (2014-01-14 07:38:14 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/126093010/1890001
6 years, 11 months ago (2014-01-14 08:08:16 UTC) #32
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 14:20:46 UTC) #33
Message was sent while issue was closed. 
Change committed as 244697

Powered by Google App Engine
This is Rietveld 408576698