content/common/gpu/client/context_provider_web_context.h - Issue 126093010: Use ContextProvider subclass to provide WGC3D pointers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/gpu/client/context_provider_web_context.h

Issue 126093010: Use ContextProvider subclass to provide WGC3D pointers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/common/gpu/client/context_provider_command_buffer.h ('K') | « content/common/gpu/client/context_provider_command_buffer.cc ('k') | content/content_common.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_RENDERER_CONTEXT_PROVIDER_WEB_CONTEXT_H_

	6 #define CONTENT_RENDERER_CONTEXT_PROVIDER_WEB_CONTEXT_H_

	7

	8 #include "cc/output/context_provider.h"

	9

	10 namespace blink { class WebGraphicsContext3D; }

	11

	12 namespace content {

	13

	14 class ContextProviderWebContext : public cc::ContextProvider {

	15 public:

	16 virtual blink::WebGraphicsContext3D* WebContext3D() = 0;

	17

	18 protected:

	19 friend class RefCountedThreadSafe<ContextProviderWebContext>;
	piman 2014/01/08 01:22:50 nit: why do you need this? nit: why do you need this? jamesr 2014/01/08 02:20:15 hmm, thought that i did since the d'tor is protect Show quoted text On 2014/01/08 01:22:50, piman (OOO back 2014-1-7) wrote: > nit: why do you need this? hmm, thought that i did since the d'tor is protected but the compiler says i don't. removed piman 2014/01/08 02:26:41 One thing that gives it away is that the RefCounte Show quoted text On 2014/01/08 02:20:15, jamesr wrote: > On 2014/01/08 01:22:50, piman (OOO back 2014-1-7) wrote: > > nit: why do you need this? > > hmm, thought that i did since the d'tor is protected but the compiler says i > don't. removed One thing that gives it away is that the RefCountedThreadSafe<ContextProviderWebContext> specialization is never otherwise instantiated :) scoped_refptr<ContextProviderWebContext> would call cc::ContextProvider::Release() which is RefCountedThreadSafe<cc::ContextProvider>::Release(), that would call cc::ContextProvider::~ContextProvider (which is fine since ContextProvider friends RefCountedThreadSafe<cc::ContextProvider>), which, being virtual, ends up being ContextProviderWebContext::~ContextProviderWebContext().
	20 virtual ~ContextProviderWebContext() {}

	21 };

	22

	23 } // namespace content

	24

	25 #endif // CONTENT_RENDERER_CONTEXT_PROVIDER_WEB_CONTEXT_H_

OLD	NEW