Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1259963002: [stubs] Don't pass name to Load/StoreGlobalViaContext stubs. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Don't pass name to Load/StoreGlobalViaContext stubs. No need to pass the name explicitly to the stubs; the runtime can extract the name from the ScopeInfo (the extension of the ScriptContext) on-demand easily without any performance impact. Committed: https://crrev.com/5dff4bdff06c0463db1e876af7541af2b715392c Cr-Commit-Position: refs/heads/master@{#29886}

Patch Set 1 #

Total comments: 2

Patch Set 2 : REBASE. #

Patch Set 3 : Fix rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -257 lines) Patch
M src/arm/code-stubs-arm.cc View 1 4 chunks +3 lines, -11 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 5 chunks +4 lines, -7 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/lithium-arm64.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 4 chunks +13 lines, -23 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 5 chunks +5 lines, -11 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/interface-descriptors.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 6 chunks +6 lines, -11 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/mips/lithium-mips.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 6 chunks +6 lines, -11 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/mips64/lithium-mips64.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 5 chunks +15 lines, -13 lines 0 comments Download
M src/scopeinfo.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 4 chunks +2 lines, -7 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
This is the (uncontroversial) b) part of https://codereview.chromium.org/1250413002/ which basically removes the need to pass ...
5 years, 4 months ago (2015-07-27 12:05:03 UTC) #2
Yang
full-codegen part lgtm.
5 years, 4 months ago (2015-07-27 12:08:06 UTC) #3
Igor Sheludko
lgtm https://codereview.chromium.org/1259963002/diff/1/src/runtime/runtime-object.cc File src/runtime/runtime-object.cc (right): https://codereview.chromium.org/1259963002/diff/1/src/runtime/runtime-object.cc#newcode460 src/runtime/runtime-object.cc:460: RUNTIME_FUNCTION(Runtime_LoadGlobalViaContext) { Why did you change the order ...
5 years, 4 months ago (2015-07-27 18:54:49 UTC) #5
Benedikt Meurer
https://codereview.chromium.org/1259963002/diff/1/src/runtime/runtime-object.cc File src/runtime/runtime-object.cc (right): https://codereview.chromium.org/1259963002/diff/1/src/runtime/runtime-object.cc#newcode460 src/runtime/runtime-object.cc:460: RUNTIME_FUNCTION(Runtime_LoadGlobalViaContext) { Leftover from unrelated change.
5 years, 4 months ago (2015-07-28 05:14:12 UTC) #6
mvstanton
Code stubs: LGTM.
5 years, 4 months ago (2015-07-28 05:43:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259963002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259963002/60001
5 years, 4 months ago (2015-07-28 05:44:41 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 4 months ago (2015-07-28 06:04:12 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 06:04:36 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5dff4bdff06c0463db1e876af7541af2b715392c
Cr-Commit-Position: refs/heads/master@{#29886}

Powered by Google App Engine
This is Rietveld 408576698