Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: src/compiler/js-generic-lowering.cc

Issue 1259963002: [stubs] Don't pass name to Load/StoreGlobalViaContext stubs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-generic-lowering.cc
diff --git a/src/compiler/js-generic-lowering.cc b/src/compiler/js-generic-lowering.cc
index 29a2a4a97eb9b5eef676a675c17096d1c4a958ba..e823b35f57c1df43dc21fb2c34fe36d4fb7b269d 100644
--- a/src/compiler/js-generic-lowering.cc
+++ b/src/compiler/js-generic-lowering.cc
@@ -339,9 +339,9 @@ void JSGenericLowering::LowerJSLoadGlobal(Node* node) {
Callable callable = CodeFactory::LoadGlobalViaContext(isolate(), 0);
Node* script_context = node->InputAt(0);
node->ReplaceInput(0, jsgraph()->Int32Constant(p.slot_index()));
- node->ReplaceInput(1, jsgraph()->HeapConstant(p.name()));
- node->ReplaceInput(2, script_context); // Set new context...
- node->RemoveInput(3); // ...instead of old one.
+ node->ReplaceInput(1, script_context); // Set new context...
+ node->RemoveInput(2);
+ node->RemoveInput(2); // ...instead of old one.
ReplaceWithStubCall(node, callable, flags);
} else {
@@ -402,10 +402,10 @@ void JSGenericLowering::LowerJSStoreGlobal(Node* node) {
Node* script_context = node->InputAt(0);
Node* value = node->InputAt(2);
node->ReplaceInput(0, jsgraph()->Int32Constant(p.slot_index()));
- node->ReplaceInput(1, jsgraph()->HeapConstant(p.name()));
- node->ReplaceInput(2, value);
- node->ReplaceInput(3, script_context); // Set new context...
- node->RemoveInput(4); // ...instead of old one.
+ node->ReplaceInput(1, value);
+ node->ReplaceInput(2, script_context); // Set new context...
+ node->RemoveInput(3);
+ node->RemoveInput(3); // ...instead of old one.
ReplaceWithStubCall(node, callable, flags);
} else {
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698