Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: src/x64/code-stubs-x64.cc

Issue 1259963002: [stubs] Don't pass name to Load/StoreGlobalViaContext stubs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/scopeinfo.cc ('k') | src/x64/interface-descriptors-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x64/code-stubs-x64.cc
diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc
index d7b7f400f4047874389243c69bac45069f67efda..7d717015ab15eafca2e406bcd00bbe0aeded2864 100644
--- a/src/x64/code-stubs-x64.cc
+++ b/src/x64/code-stubs-x64.cc
@@ -5036,7 +5036,6 @@ void InternalArrayConstructorStub::Generate(MacroAssembler* masm) {
void LoadGlobalViaContextStub::Generate(MacroAssembler* masm) {
Register context_reg = rsi;
Register slot_reg = rbx;
- Register name_reg = rcx;
Register result_reg = rax;
Label slow_case;
@@ -5060,16 +5059,14 @@ void LoadGlobalViaContextStub::Generate(MacroAssembler* masm) {
__ Integer32ToSmi(slot_reg, slot_reg);
__ PopReturnAddressTo(kScratchRegister);
__ Push(slot_reg);
- __ Push(name_reg);
__ Push(kScratchRegister);
- __ TailCallRuntime(Runtime::kLoadGlobalViaContext, 2, 1);
+ __ TailCallRuntime(Runtime::kLoadGlobalViaContext, 1, 1);
}
void StoreGlobalViaContextStub::Generate(MacroAssembler* masm) {
Register context_reg = rsi;
Register slot_reg = rbx;
- Register name_reg = rcx;
Register value_reg = rax;
Register cell_reg = r8;
Register cell_details_reg = rdx;
@@ -5079,7 +5076,6 @@ void StoreGlobalViaContextStub::Generate(MacroAssembler* masm) {
if (FLAG_debug_code) {
__ CompareRoot(value_reg, Heap::kTheHoleValueRootIndex);
__ Check(not_equal, kUnexpectedValue);
- __ AssertName(name_reg);
}
// Go up context chain to the script context.
@@ -5183,13 +5179,12 @@ void StoreGlobalViaContextStub::Generate(MacroAssembler* masm) {
__ Integer32ToSmi(slot_reg, slot_reg);
__ PopReturnAddressTo(kScratchRegister);
__ Push(slot_reg);
- __ Push(name_reg);
__ Push(value_reg);
__ Push(kScratchRegister);
__ TailCallRuntime(is_strict(language_mode())
? Runtime::kStoreGlobalViaContext_Strict
: Runtime::kStoreGlobalViaContext_Sloppy,
- 3, 1);
+ 2, 1);
}
« no previous file with comments | « src/scopeinfo.cc ('k') | src/x64/interface-descriptors-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698