Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: src/hydrogen-instructions.h

Issue 1259963002: [stubs] Don't pass name to Load/StoreGlobalViaContext stubs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index 3d3c56cc4063d4ad4859b060a9509c92be84da58..63ddf2789ac0ebb5f198d76aa4338e0f05ac8928 100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -5496,11 +5496,9 @@ class HLoadGlobalGeneric final : public HTemplateInstruction<2> {
class HLoadGlobalViaContext final : public HTemplateInstruction<1> {
public:
- DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P3(HLoadGlobalViaContext,
- Handle<String>, int, int);
+ DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P2(HLoadGlobalViaContext, int, int);
HValue* context() { return OperandAt(0); }
- Handle<String> name() const { return name_; }
int depth() const { return depth_; }
int slot_index() const { return slot_index_; }
@@ -5513,17 +5511,15 @@ class HLoadGlobalViaContext final : public HTemplateInstruction<1> {
DECLARE_CONCRETE_INSTRUCTION(LoadGlobalViaContext)
private:
- HLoadGlobalViaContext(HValue* context, Handle<String> name, int depth,
- int slot_index)
- : name_(name), depth_(depth), slot_index_(slot_index) {
+ HLoadGlobalViaContext(HValue* context, int depth, int slot_index)
+ : depth_(depth), slot_index_(slot_index) {
SetOperandAt(0, context);
set_representation(Representation::Tagged());
SetAllSideEffects();
}
- Handle<String> name_;
- int depth_;
- int slot_index_;
+ int const depth_;
+ int const slot_index_;
};
@@ -7069,12 +7065,10 @@ class HStoreNamedGeneric final : public HTemplateInstruction<3> {
class HStoreGlobalViaContext final : public HTemplateInstruction<2> {
public:
- DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P5(HStoreGlobalViaContext,
- Handle<String>, HValue*, int, int,
- LanguageMode);
+ DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P4(HStoreGlobalViaContext, HValue*,
+ int, int, LanguageMode);
HValue* context() const { return OperandAt(0); }
HValue* value() const { return OperandAt(1); }
- Handle<String> name() const { return name_; }
int depth() const { return depth_; }
int slot_index() const { return slot_index_; }
LanguageMode language_mode() const { return language_mode_; }
@@ -7088,21 +7082,17 @@ class HStoreGlobalViaContext final : public HTemplateInstruction<2> {
DECLARE_CONCRETE_INSTRUCTION(StoreGlobalViaContext)
private:
- HStoreGlobalViaContext(HValue* context, Handle<String> name, HValue* value,
- int depth, int slot_index, LanguageMode language_mode)
- : name_(name),
- depth_(depth),
- slot_index_(slot_index),
- language_mode_(language_mode) {
+ HStoreGlobalViaContext(HValue* context, HValue* value, int depth,
+ int slot_index, LanguageMode language_mode)
+ : depth_(depth), slot_index_(slot_index), language_mode_(language_mode) {
SetOperandAt(0, context);
SetOperandAt(1, value);
SetAllSideEffects();
}
- Handle<String> name_;
- int depth_;
- int slot_index_;
- LanguageMode language_mode_;
+ int const depth_;
+ int const slot_index_;
+ LanguageMode const language_mode_;
};
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698