Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1259193003: Add priority to Notification & NotificationOptions. (Closed)

Created:
5 years, 4 months ago by johnme
Modified:
5 years ago
Reviewers:
Peter Beverloo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@actions3
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add priority to Notification & NotificationOptions. Spec proposal: https://github.com/whatwg/notifications/issues/49 DO NOT LAND before intent to implement gets sent out. BUG=460089

Patch Set 1 #

Patch Set 2 : Lowest to highest enum order #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -4 lines) Patch
M LayoutTests/http/tests/notifications/notification-properties.html View 3 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html View 2 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/notifications/Notification.h View 6 chunks +8 lines, -0 lines 2 comments Download
M Source/modules/notifications/Notification.cpp View 1 6 chunks +43 lines, -3 lines 0 comments Download
M Source/modules/notifications/Notification.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/notifications/NotificationOptions.idl View 1 1 chunk +9 lines, -0 lines 0 comments Download
M Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M public/platform/modules/notifications/WebNotificationData.h View 1 4 chunks +28 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1263043003 Patch 100001

Dependent Patchsets:

Issue 1260793007 Patch 40001

Messages

Total messages: 6 (2 generated)
johnme
5 years, 4 months ago (2015-08-03 15:42:36 UTC) #2
Peter Beverloo
lgtm, but please do not land this until the Intent to Implement has been send ...
5 years, 4 months ago (2015-08-03 16:41:59 UTC) #3
johnme
https://codereview.chromium.org/1259193003/diff/20001/Source/modules/notifications/Notification.h File Source/modules/notifications/Notification.h (right): https://codereview.chromium.org/1259193003/diff/20001/Source/modules/notifications/Notification.h#newcode167 Source/modules/notifications/Notification.h:167: String m_priority; On 2015/08/03 16:41:59, Peter Beverloo wrote: > ...
5 years, 4 months ago (2015-08-03 16:58:48 UTC) #4
johnme
5 years ago (2015-11-24 16:02:03 UTC) #6
Message was sent while issue was closed. 
Putting this patch on ice for now. We might revisit it later.

Powered by Google App Engine
This is Rietveld 408576698