Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp - Issue 1259193003: Add priority to Notification & NotificationOptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

Issue 1259193003: Add priority to Notification & NotificationOptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@actions3

Patch Set: Lowest to highest enum order Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/notifications/Notification.h ('K') | « Source/modules/notifications/NotificationOptions.idl ('k') | public/platform/modules/notifications/WebNotificationData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

diff --git a/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp b/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

index a30a13ebdce6b5aa0bb1b42ec950a78bb1e3af6a..c42f89a266263d627343d443139c40807d59b633 100644

--- a/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

+++ b/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

@@ -93,10 +93,11 @@ ScriptPromise ServiceWorkerRegistrationNotifications::showNotification(ScriptSta

}

WebNotificationData::Direction dir = options.dir() == "rtl" ? WebNotificationData::DirectionRightToLeft : WebNotificationData::DirectionLeftToRight;

+ WebNotificationData::Priority priority = Notification::priorityEnum(options.priority());

NavigatorVibration::VibrationPattern vibrate = NavigatorVibration::sanitizeVibrationPattern(options.vibrate());

WebVector<WebNotificationAction> webActions;

Notification::actionsToWebActions(options.actions(), &webActions);

- WebNotificationData notification(title, dir, options.lang(), options.body(), options.tag(), iconUrl, vibrate, options.silent(), dataAsWireBytes, webActions);

+ WebNotificationData notification(title, dir, options.lang(), options.body(), options.tag(), priority, iconUrl, vibrate, options.silent(), dataAsWireBytes, webActions);

WebNotificationShowCallbacks* callbacks = new CallbackPromiseAdapter<void, void>(resolver);

SecurityOrigin* origin = executionContext->securityOrigin();