Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html

Issue 1259193003: Add priority to Notification & NotificationOptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@actions3
Patch Set: Lowest to highest enum order Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html
diff --git a/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html b/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html
index ad8f02c5f3871e58fabc955178b7a51ec872a645..73c7ef1aac139e3d3eee5d1692c485992ed1192e 100644
--- a/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html
+++ b/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html
@@ -23,6 +23,7 @@
lang: 'nl-NL',
body: 'Hello, world!',
tag: 'tag',
+ priority: 'high',
// FIXME: Relative URLs for the icon attribute currently get reflected as
// an absolute URL, which should probably be the given relative URL.
icon: 'https://example/icon.png',
@@ -69,6 +70,10 @@
assert_equals(event.data.command, 'click', 'The notification was expected to be clicked.');
Object.keys(options).forEach(function(key) {
+ if (key == 'priority') {
+ // TODO(johnme): priority is not yet serialized properly.
+ return;
+ }
if (key == 'actions') {
// TODO(johnme): actions are not yet serialized properly.
return;

Powered by Google App Engine
This is Rietveld 408576698