Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1257603003: Revert of Add ExecuteJavaScriptForTest and make all tests use it (Closed)

Created:
5 years, 5 months ago by sof
Modified:
5 years, 5 months ago
CC:
aandrey+blink_chromium.org, aboxhall+watch_chromium.org, asanka, benjhayden+dwatch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, davidben+watch_chromium.org, devtools-reviews_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, dzhioev+watch_chromium.org, eroman, estade+watch_chromium.org, extensions-reviews_chromium.org, gavinp+prer_chromium.org, Greg Billock, gcasto+watchlist_chromium.org, grt+watch_chromium.org, jam, je_julie(Not used), mkwst+watchlist-passwords_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-geolocation_chromium.org, mlamouri+watch-content_chromium.org, mmenke, Michael van Ouwerkerk, nasko+codewatch_chromium.org, nektar+watch_chromium.org, oshima+watch_chromium.org, pfeldman, plundblad+watch_chromium.org, rouslan+autofillwatch_chromium.org, stevenjb+watch_chromium.org, tburkard+watch_chromium.org, tfarina, Lei Zhang, tommycli, vabr+watchlist_chromium.org, vandebo (ex-Chrome), yurys, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add ExecuteJavaScriptForTest and make all tests use it (patchset #15 id:270001 of https://codereview.chromium.org/1123783002/) Reason for revert: Speculatively reverting to address failures, http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/51422 Original issue's description: > Add ExecuteJavaScriptForTest and make all tests use it > > Additionally, restrict the URLs that ExecuteJavaScript can be invoked on > to chrome-controlled URLs. > > R=jam@chromium.org > BUG=507809 > > Committed: https://crrev.com/904f14ebdc3bdb8e893df0a3211d09de42d5619c > Cr-Commit-Position: refs/heads/master@{#340231} TBR=jam@chromium.org,mdjones@chromium.org,torne@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507809 Committed: https://crrev.com/f08040289fb0ed72c792863d2dab73fe4d1ca943 Cr-Commit-Position: refs/heads/master@{#340241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -301 lines) Patch
M android_webview/browser/aw_browser_main_parts.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +0 lines, -16 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java View 5 chunks +5 lines, -5 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/JavaScriptEvalChromeTest.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/apps/custom_launcher_page_browsertest_views.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker_tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/alert_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/mouseleave_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/web_ui_test_handler.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/renderer/autofill/autofill_renderer_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/form_autocomplete_browsertest.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/page_click_tracker_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/password_generation_agent_browsertest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M components/dom_distiller/content/browser/distiller_page_web_contents_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/printing/test/print_web_view_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/accessibility_win_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/dump_accessibility_events_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 5 chunks +0 lines, -40 lines 0 comments Download
M content/browser/web_contents/web_contents_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 2 chunks +1 line, -8 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/WebContents.java View 1 chunk +1 line, -16 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java View 4 chunks +4 lines, -4 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBareboneTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/NavigationTest.java View 2 chunks +2 lines, -4 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/TestsJavaScriptEvalTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/render_frame_host.h View 2 chunks +2 lines, -14 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/JavaScriptUtils.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/render_view_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/accessibility/renderer_accessibility_browsertest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/devtools/v8_sampling_profiler_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 15 chunks +21 lines, -23 lines 0 comments Download
M content/renderer/render_view_browsertest_mac.mm View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/api/system_storage/system_storage_eject_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sof
Created Revert of Add ExecuteJavaScriptForTest and make all tests use it
5 years, 5 months ago (2015-07-24 08:40:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257603003/1
5 years, 5 months ago (2015-07-24 08:40:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 08:41:30 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 08:42:31 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f08040289fb0ed72c792863d2dab73fe4d1ca943
Cr-Commit-Position: refs/heads/master@{#340241}

Powered by Google App Engine
This is Rietveld 408576698