android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java - Issue 1257603003: Revert of Add ExecuteJavaScriptForTest and make all tests use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

Issue 1257603003: Revert of Add ExecuteJavaScriptForTest and make all tests use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

index dec1762a8055e8979fe996ae2d61cea1f056d5fb..11eb3c5e19abd3816d73f55f06144b43b85f3328 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

@@ -588,7 +588,7 @@

TestAwContentsClient.OnCreateWindowHelper onCreateWindowHelper =

parentAwContentsClient.getOnCreateWindowHelper();

int currentCallCount = onCreateWindowHelper.getCallCount();

- parentAwContents.evaluateJavaScriptForTests(triggerScript, null);

+ parentAwContents.evaluateJavaScript(triggerScript, null);

onCreateWindowHelper.waitForCallback(

currentCallCount, 1, WAIT_TIMEOUT_MS, TimeUnit.MILLISECONDS);

}