android_webview/java/src/org/chromium/android_webview/AwContents.java - Issue 1257603003: Revert of Add ExecuteJavaScriptForTest and make all tests use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 1257603003: Revert of Add ExecuteJavaScriptForTest and make all tests use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/aw_browser_main_parts.cc ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContents.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java

index 8874bd7375ea74006664616fe1e7e41e5c7d1327..3b7a1654a3c6bef5b674c891f1e32949adcafc86 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java

@@ -2069,22 +2069,6 @@

mWebContents.evaluateJavaScript(script, jsCallback);

}

- public void evaluateJavaScriptForTests(String script, final ValueCallback<String> callback) {

- if (TRACE) Log.d(TAG, "evaluateJavascriptForTests=" + script);

- if (isDestroyed()) return;

- JavaScriptCallback jsCallback = null;

- if (callback != null) {

- jsCallback = new JavaScriptCallback() {

- @Override

- public void handleJavaScriptResult(String jsonResult) {

- callback.onReceiveValue(jsonResult);

- }

- };

- }

- mWebContents.evaluateJavaScriptForTests(script, jsCallback);

- }

/**

* Post a message to a frame.