content/browser/frame_host/render_frame_host_impl.h - Issue 1257603003: Revert of Add ExecuteJavaScriptForTest and make all tests use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1257603003: Revert of Add ExecuteJavaScriptForTest and make all tests use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/dump_accessibility_events_browsertest.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index b4e9442483c52c351978c307e92f55761676f0c6..8035992f329c48e9be608dc927e3eedd2b64efe7 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -139,10 +139,6 @@

void ExecuteJavaScript(const base::string16& javascript) override;

void ExecuteJavaScript(const base::string16& javascript,

const JavaScriptResultCallback& callback) override;

- void ExecuteJavaScriptForTests(const base::string16& javascript) override;

- void ExecuteJavaScriptForTests(

- const base::string16& javascript,

- const JavaScriptResultCallback& callback) override;

void ExecuteJavaScriptWithUserGestureForTests(

const base::string16& javascript) override;

void ExecuteJavaScriptInIsolatedWorld(

@@ -588,9 +584,6 @@

const CommonNavigationParams& common_params,

const RequestNavigationParams& request_params);

- // Returns true if the ExecuteJavaScript() API can be used on this host.

- bool CanExecuteJavaScript();

// For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a

// refcount that calls Shutdown when it reaches zero. This allows each

// RenderFrameHostManager to just care about RenderFrameHosts, while ensuring