Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1260053003: Update contents to use attachment broker. (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@ipc_refactor2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update content/ to use new attachment broker interface. Now that more of the attachment broker API has been finalized, update content/ to correctly set up and use attachment brokers. BUG=493414 Committed: https://crrev.com/1bfccba17a0828045671935031c8dcdf636e42e2 Cr-Commit-Position: refs/heads/master@{#341254}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Minor adjustments. #

Patch Set 4 : #

Patch Set 5 : compile error. #

Patch Set 6 : #

Total comments: 1

Patch Set 7 : Use new api. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M content/child/child_thread_impl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/child_process_host_impl.cc View 1 2 3 4 5 6 3 chunks +9 lines, -3 lines 0 comments Download
M content/public/common/child_process_host.h View 1 2 3 4 5 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260053003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260053003/60001
5 years, 4 months ago (2015-07-29 01:23:21 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/83664)
5 years, 4 months ago (2015-07-29 01:52:14 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260053003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260053003/80001
5 years, 4 months ago (2015-07-29 17:51:14 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/86014) win_chromium_x64_rel_ng on ...
5 years, 4 months ago (2015-07-29 18:29:53 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260053003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260053003/100001
5 years, 4 months ago (2015-07-29 20:12:51 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-29 21:33:45 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260053003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260053003/120001
5 years, 4 months ago (2015-07-30 17:24:35 UTC) #14
erikchen
avi: Please review. https://codereview.chromium.org/1260053003/diff/100001/content/public/common/child_process_host.h File content/public/common/child_process_host.h (right): https://codereview.chromium.org/1260053003/diff/100001/content/public/common/child_process_host.h#newcode11 content/public/common/child_process_host.h:11: #include "ipc/attachment_broker_privileged.h" Some consumers want an ...
5 years, 4 months ago (2015-07-30 17:24:40 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/97543) cast_shell_linux on ...
5 years, 4 months ago (2015-07-30 17:37:41 UTC) #18
Avi (use Gerrit)
lgtm
5 years, 4 months ago (2015-07-30 19:09:35 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260053003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260053003/120001
5 years, 4 months ago (2015-07-31 00:08:55 UTC) #23
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 4 months ago (2015-07-31 01:09:44 UTC) #24
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 01:10:23 UTC) #25
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/1bfccba17a0828045671935031c8dcdf636e42e2
Cr-Commit-Position: refs/heads/master@{#341254}

Powered by Google App Engine
This is Rietveld 408576698