Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: ipc/attachment_broker_privileged_win.h

Issue 1256993003: ipc: Create AttachmentBrokerPrivileged and AttachmentBrokerUnprivileged. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_ipc_message_feature
Patch Set: Rebase. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/attachment_broker_privileged_win.h
diff --git a/ipc/attachment_broker_privileged_win.h b/ipc/attachment_broker_privileged_win.h
index 66bf788311e23dfc3ac57addcbe5bb329ed25a88..dca05f5747870ce68b86c08bd172636f449313b4 100644
--- a/ipc/attachment_broker_privileged_win.h
+++ b/ipc/attachment_broker_privileged_win.h
@@ -5,21 +5,16 @@
#ifndef IPC_ATTACHMENT_BROKER_PRIVILEGED_WIN_H_
#define IPC_ATTACHMENT_BROKER_PRIVILEGED_WIN_H_
-#include <vector>
-
-#include "ipc/attachment_broker.h"
+#include "ipc/attachment_broker_privileged.h"
#include "ipc/handle_attachment_win.h"
#include "ipc/ipc_export.h"
namespace IPC {
-class Channel;
-
-// This class is an implementation of AttachmentBroker for a privileged process
-// on the Windows platform. When unprivileged processes want to send
-// attachments, the attachments get routed through the privileged process, and
-// more specifically, an instance of this class.
-class IPC_EXPORT AttachmentBrokerPrivilegedWin : public AttachmentBroker {
+// This class is a concrete subclass of AttachmentBrokerPrivileged for the
+// Windows platform.
+class IPC_EXPORT AttachmentBrokerPrivilegedWin
+ : public AttachmentBrokerPrivileged {
public:
AttachmentBrokerPrivilegedWin();
~AttachmentBrokerPrivilegedWin() override;
@@ -31,13 +26,6 @@ class IPC_EXPORT AttachmentBrokerPrivilegedWin : public AttachmentBroker {
// IPC::Listener overrides.
bool OnMessageReceived(const Message& message) override;
- // Each unprivileged process should have one IPC channel on which it
- // communicates attachment information with this privileged process. These
- // channels must be registered and deregistered with the Attachment Broker as
- // they are created and destroyed.
- void RegisterCommunicationChannel(Channel* channel);
- void DeregisterCommunicationChannel(Channel* channel);
-
private:
using HandleWireFormat = internal::HandleAttachmentWin::WireFormat;
// IPC message handlers.
@@ -52,7 +40,6 @@ class IPC_EXPORT AttachmentBrokerPrivilegedWin : public AttachmentBroker {
// observers. Otherwise, send it in an IPC to its destination.
void RouteDuplicatedHandle(const HandleWireFormat& wire_format);
- std::vector<Channel*> channels_;
DISALLOW_COPY_AND_ASSIGN(AttachmentBrokerPrivilegedWin);
};

Powered by Google App Engine
This is Rietveld 408576698