Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1255883002: VectorICs: vector [keyed]store ic MISS handling infrastructure. (Closed)

Created:
5 years, 5 months ago by mvstanton
Modified:
5 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

VectorICs: vector [keyed]store ic MISS handling infrastructure. BUG= Committed: https://crrev.com/a913f4bf5c40ef88c52e7cf821540f0faf5524f9 Cr-Commit-Position: refs/heads/master@{#29870}

Patch Set 1 #

Total comments: 2

Patch Set 2 : REBASE and nit fixin. #

Patch Set 3 : Macro assembler fixes on arm, mips, mips64. #

Total comments: 1

Patch Set 4 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -66 lines) Patch
M src/arm/macro-assembler-arm.h View 1 2 3 5 chunks +34 lines, -18 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 2 chunks +19 lines, -7 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 2 2 chunks +19 lines, -8 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 3 chunks +22 lines, -9 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 2 chunks +20 lines, -7 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 2 chunks +20 lines, -7 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 3 chunks +15 lines, -6 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
mvstanton
Hi Jakob, Here is support for vector stores to call MISS handlers appropriately. Also removed ...
5 years, 5 months ago (2015-07-24 13:13:20 UTC) #2
Jakob Kummerow
LGTM with a nit. https://codereview.chromium.org/1255883002/diff/1/src/ic/ia32/ic-ia32.cc File src/ic/ia32/ic-ia32.cc (right): https://codereview.chromium.org/1255883002/diff/1/src/ic/ia32/ic-ia32.cc#newcode763 src/ic/ia32/ic-ia32.cc:763: __ push(receiver); // which contains ...
5 years, 4 months ago (2015-07-27 11:11:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255883002/20001
5 years, 4 months ago (2015-07-27 11:21:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/6270) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 4 months ago (2015-07-27 11:22:42 UTC) #8
Jakob Kummerow
Patch set 3 LGTM with a new nit. https://codereview.chromium.org/1255883002/diff/60001/src/arm/macro-assembler-arm.h File src/arm/macro-assembler-arm.h (right): https://codereview.chromium.org/1255883002/diff/60001/src/arm/macro-assembler-arm.h#newcode380 src/arm/macro-assembler-arm.h:380: DCHECK(!src1.is(src2)); ...
5 years, 4 months ago (2015-07-27 12:16:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255883002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255883002/80001
5 years, 4 months ago (2015-07-27 12:26:24 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 4 months ago (2015-07-27 12:50:03 UTC) #14
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/a913f4bf5c40ef88c52e7cf821540f0faf5524f9 Cr-Commit-Position: refs/heads/master@{#29870}
5 years, 4 months ago (2015-07-27 12:50:26 UTC) #15
Michael Achenbach
This from here? http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%201/builds/4380 http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/3024
5 years, 4 months ago (2015-07-27 15:52:27 UTC) #16
mvstanton
Hi Michael, it's pretty unlikely that those OSR failures are due to this. It only ...
5 years, 4 months ago (2015-07-28 05:39:03 UTC) #17
Michael Achenbach
5 years, 4 months ago (2015-07-28 07:33:05 UTC) #18
Message was sent while issue was closed. 
On 2015/07/28 05:39:03, mvstanton wrote:
> Hi Michael, it's pretty unlikely that those OSR failures are due to this. It
> only changes code behind a flag that is turned off in the build.
> 
> https://codereview.chromium.org/1255883002/diff/1/src/ic/ia32/ic-ia32.cc
> File src/ic/ia32/ic-ia32.cc (right):
> 
>
https://codereview.chromium.org/1255883002/diff/1/src/ic/ia32/ic-ia32.cc#newc...
> src/ic/ia32/ic-ia32.cc:763: __ push(receiver);  // which contains the return
> address.
> On 2015/07/27 11:11:42, Jakob wrote:
> > nit: s/which c/C/ to turn the comment into a proper sentence.
> 
> Done.

OK. It also stopped and I reverted a CL from jochen in that same range for one
of the failures.

Powered by Google App Engine
This is Rietveld 408576698