Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 1255653003: Add missing runtime dependencies to *_run targets. (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, jam
CC:
chromium-reviews, extensions-reviews_chromium.org, Matt Giuca, tapted, tfarina, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing runtime dependencies to *_run targets. A follow up CL removes dynamic libraries that would be fetched automatically via implicit dependencies. The target hierarchy needs to be there in the first place for this to work. This is a redo of d7b8df80cd5ce2a882bbf35482dc21cee34934f9 but with a fix for iOS and update to BUILD.gn files. TBR=jam@chromium.org,dpranke@chromium.org BUG=98637 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ac2496af24009df795fe0dc33d419e8a4971a8ec Cr-Commit-Position: refs/heads/master@{#346705}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M cc/cc_tests.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 3 chunks +4 lines, -1 line 0 comments Download
M extensions/extensions_tests.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/wm/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M ui/wm/wm.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
M-A Ruel
Sorry for the delays, travelling and vacations, the goal is to finally fix https://codereview.chromium.org/1242783002.
5 years, 3 months ago (2015-09-01 18:01:55 UTC) #4
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-01 18:50:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255653003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255653003/40001
5 years, 3 months ago (2015-09-01 19:09:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/95313)
5 years, 3 months ago (2015-09-01 19:20:01 UTC) #9
M-A Ruel
On 2015/09/01 19:20:01, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 3 months ago (2015-09-01 19:22:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255653003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255653003/40001
5 years, 3 months ago (2015-09-01 19:23:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 3 months ago (2015-09-01 19:29:51 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ac2496af24009df795fe0dc33d419e8a4971a8ec Cr-Commit-Position: refs/heads/master@{#346705}
5 years, 3 months ago (2015-09-01 19:30:24 UTC) #14
M-A Ruel
5 years, 3 months ago (2015-09-01 19:51:28 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:40001) has been created in
https://codereview.chromium.org/1314313003/ by maruel@chromium.org.

The reason for reverting is: Broke iOS Device builder again.

It fetched by accident osmesa again. Will have to investigate which target does
this.

Ref:
http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/19013.

Powered by Google App Engine
This is Rietveld 408576698