Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 1314313003: Revert of Add missing runtime dependencies to *_run targets. (Closed)

Created:
5 years, 3 months ago by M-A Ruel
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, jam
CC:
chromium-reviews, extensions-reviews_chromium.org, Matt Giuca, tapted, tfarina, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add missing runtime dependencies to *_run targets. (patchset #1 id:40001 of https://codereview.chromium.org/1255653003/ ) Reason for revert: Broke iOS Device builder again. It fetched by accident osmesa again. Will have to investigate which target does this. Ref: http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/19013 Original issue's description: > Add missing runtime dependencies to *_run targets. > > A follow up CL removes dynamic libraries that would be fetched automatically via > implicit dependencies. The target hierarchy needs to be there in the first > place for this to work. > > This is a redo of d7b8df80cd5ce2a882bbf35482dc21cee34934f9 but with a fix for > iOS and update to BUILD.gn files. > > TBR=jam@chromium.org,dpranke@chromium.org > BUG=98637 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/ac2496af24009df795fe0dc33d419e8a4971a8ec > Cr-Commit-Position: refs/heads/master@{#346705} TBR=jam@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Committed: https://crrev.com/fcc6f84e631ed578ac6d52fde2d260a40a0220e9 Cr-Commit-Position: refs/heads/master@{#346713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -26 lines) Patch
M cc/cc_tests.gyp View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 3 chunks +1 line, -4 lines 0 comments Download
M extensions/extensions_tests.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/wm/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M ui/wm/wm.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
Created Revert of Add missing runtime dependencies to *_run targets.
5 years, 3 months ago (2015-09-01 19:51:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314313003/1
5 years, 3 months ago (2015-09-01 19:51:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 19:52:22 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fcc6f84e631ed578ac6d52fde2d260a40a0220e9 Cr-Commit-Position: refs/heads/master@{#346713}
5 years, 3 months ago (2015-09-01 19:53:07 UTC) #4
Dirk Pranke
5 years, 3 months ago (2015-09-01 20:03:01 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698