Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1242783002:
Modify isolate_driver.py to always generate a wrapping .isolate. (Closed)
|
Created:
5 years, 5 months ago by M-A Ruel Modified:
5 years, 3 months ago Reviewers:
jam CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, chromoting-reviews_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, peter+watch_chromium.org, ben+mojo_chromium.org, extensions-reviews_chromium.org, Matt Giuca, jdduke+watch_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, darin-cc_chromium.org, darin (slow to review), chromium-apps-reviews_chromium.org, tdresser+watch_chromium.org, erikwright+watch_chromium.org, tapted, mlamouri+watch-notifications_chromium.org, media-router+watch_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, Ian Vollick, tfarina, Aaron Boodman, danakj+watch_chromium.org, Dirk Pranke, Nico Base URL:
https://chromium.googlesource.com/a/chromium/src.git@1_read_only Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionModify isolate_driver.py to always generate a wrapping .isolate.
This permits to trim dependencies as they are not necessary anymore. This will
enable greatly simplifying .isolate files, reduce the manual work involved in
adding static libraries and reduce the noise for the GN conversion.
The other end goal is to support automatic archival of debug symbols, which will
be done in a follow up CL.
R=jam@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/ec88a1ec7fc1b6248e30776cb47cd434a6b7c05e
Cr-Commit-Position: refs/heads/master@{#346901}
Patch Set 1 : Testing, ignore #Patch Set 2 : . #
Messages
Total messages: 28 (18 generated)
maruel@chromium.org changed reviewers: - dpranke@chromium.org, thakis@chromium.org
Patchset #1 (id:1) has been deleted
The CQ bit was checked by maruel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242783002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
nice, lgtm
On 2015/07/20 18:40:20, jam wrote: > nice, lgtm Oh sorry, it's not ready for review yet. I had a hard time testing on my laptop so I knew it wasn't fully working yet. I need to fix all the failures, which may take a while, likely I need to add all the missing target dependencies.
The CQ bit was checked by maruel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242783002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1242783002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
Patchset #1 (id:100001) has been deleted
Patchset #3 (id:160001) has been deleted
Patchset #2 (id:140001) has been deleted
Patchset #2 (id:180001) has been deleted
Patchset #3 (id:220001) has been deleted
Patchset #2 (id:200001) has been deleted
Initially I wanted to trim the .isolate right away as much as possible but this quickly became a rabbit hole. So I'm enabling it then will trim the .isolate slowly.
The CQ bit was checked by maruel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org Link to the patchset: https://codereview.chromium.org/1242783002/#ps240001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242783002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1242783002/240001
Message was sent while issue was closed.
Committed patchset #2 (id:240001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ec88a1ec7fc1b6248e30776cb47cd434a6b7c05e Cr-Commit-Position: refs/heads/master@{#346901} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
