Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1254963006: Rename SkCodec_libbmp to SkBmpCodec (Closed)

Created:
5 years, 4 months ago by msarett
Modified:
5 years, 4 months ago
Reviewers:
scroggo, emmaleer
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename SkCodec_libbmp to SkBmpCodec BUG=skia: Committed: https://skia.googlesource.com/skia/+/b46e5e2033e4ef25c515adf780a4e0d007da0d20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1431 lines) Patch
M gyp/codec.gyp View 1 chunk +1 line, -1 line 0 comments Download
A + src/codec/SkBmpCodec.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/codec/SkBmpCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
D src/codec/SkCodec_libbmp.h View 1 chunk +0 lines, -193 lines 0 comments Download
D src/codec/SkCodec_libbmp.cpp View 1 chunk +0 lines, -1235 lines 0 comments Download
M src/codec/SkCodec_libico.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1188223002 Patch 1

Messages

Total messages: 8 (2 generated)
msarett
5 years, 4 months ago (2015-07-30 18:13:12 UTC) #1
msarett
Adding reviewiers :)
5 years, 4 months ago (2015-07-30 18:22:27 UTC) #3
scroggo
lgtm
5 years, 4 months ago (2015-07-30 18:28:02 UTC) #4
emmaleer
Looks good, lgtm
5 years, 4 months ago (2015-07-30 18:28:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254963006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254963006/1
5 years, 4 months ago (2015-07-30 18:28:40 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 18:36:42 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b46e5e2033e4ef25c515adf780a4e0d007da0d20

Powered by Google App Engine
This is Rietveld 408576698