Issue 1269003006: Plumb the anonymize rect color to toolbar_layer from Tab#getThemeColor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1269003006: Plumb the anonymize rect color to toolbar_layer from Tab#getThemeColor (Closed)

Created:
5 years, 4 months ago by Yusuf

Modified:
5 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@tabHasThemeColor

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Plumb the anonymize rect color to toolbar_layer from Tab#getThemeColor Makes LayoutTab aware of the textbox background color so that it can be used for anonymizeRect background. Changes the boolean used to set the color for anonymizeRect to be an int and signal the actual color. Adds tinting to toolbarPhone animation drawables so that fullscreen works properly. No visual changes. Yet. BUG=507340

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -16 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java	View	3 chunks	+11 lines, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/document/BrandColorUtils.java	View	2 chunks	+20 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherDrawable.java	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/android/compositor/compositor_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/compositor/layer/tab_layer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/android/compositor/layer/tab_layer.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/android/compositor/layer/toolbar_layer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/compositor/layer/toolbar_layer.cc	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 1254783003 Patch 20001