Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1253223003: Update SkLightingShader to take a localMatrix (Closed)

Created:
5 years, 4 months ago by robertphillips
Modified:
5 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update SkLightingShader to take a localMatrix W/o this we can't draw lit objects anywhere but the origin. Committed: https://skia.googlesource.com/skia/+/640898f5881df1fd56d306190608dd79b1f32044

Patch Set 1 #

Patch Set 2 : Update SkLightingShader to take a localMatrix #

Patch Set 3 : Fix serialization bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -31 lines) Patch
M gm/lightingshader.cpp View 4 chunks +89 lines, -17 lines 0 comments Download
M samplecode/SampleLighting.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkLightingShader.h View 2 chunks +7 lines, -5 lines 0 comments Download
M src/effects/SkLightingShader.cpp View 1 2 5 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
robertphillips
5 years, 4 months ago (2015-07-29 20:36:59 UTC) #2
reed1
lgtm
5 years, 4 months ago (2015-07-29 20:43:34 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253223003/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253223003/30001
5 years, 4 months ago (2015-07-29 20:52:20 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-29 21:00:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253223003/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253223003/30001
5 years, 4 months ago (2015-07-30 12:08:43 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 12:09:20 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:30001) as
https://skia.googlesource.com/skia/+/640898f5881df1fd56d306190608dd79b1f32044

Powered by Google App Engine
This is Rietveld 408576698