Fix OOP iframe prototype to allow BrowserPlugin outside webview.

Fix OOP iframe prototype to allow BrowserPlugin outside webview.
Only matters for --site-per-process --enable-browser-plugin-for-all-view-types.

BUG=99379
TEST=Pages with cross-site iframes should render.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188825

[Charlie Reis, 2013-03-16 01:56:59]

Nasko, can you make sure this is right?

[nasko, 2013-03-18 14:08:47]

lgtm

[Fady Samuel, 2013-03-18 14:41:15]

https://codereview.chromium.org/12512009/diff/1/chrome/renderer/chrome_conten...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/12512009/diff/1/chrome/renderer/chrome_conten...
chrome/renderer/chrome_content_renderer_client.cc:1131: return
CommandLine::ForCurrentProcess()->HasSwitch(
While you're at it, could you please move this switch up to the top along
SitePerProcess.

[Charlie Reis, 2013-03-18 17:17:41]

Good catch!  Fady, PTAL.

https://codereview.chromium.org/12512009/diff/1/chrome/renderer/chrome_conten...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/12512009/diff/1/chrome/renderer/chrome_conten...
chrome/renderer/chrome_content_renderer_client.cc:1131: return
CommandLine::ForCurrentProcess()->HasSwitch(
On 2013/03/18 14:41:15, Fady Samuel wrote:
> While you're at it, could you please move this switch up to the top along
> SitePerProcess.

Ah!  Just doing that move would be sufficient, actually.  We wouldn't need the
site-per-process flag check as well.

Done.

[Fady Samuel, 2013-03-18 17:20:08]

lgtm

[Charlie Reis, 2013-03-18 17:22:57]

Darin, can you look for OWNERs approval?

[darin (slow to review), 2013-03-18 17:30:48]

LGTM

https://codereview.chromium.org/12512009/diff/8001/chrome/renderer/chrome_con...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/12512009/diff/8001/chrome/renderer/chrome_con...
chrome/renderer/chrome_content_renderer_client.cc:1128:
WebKit::WebString::fromUTF8(kWebViewTagName));
nit: WebString has a using directive up top.

[Charlie Reis, 2013-03-18 17:33:13]

Thanks!

https://codereview.chromium.org/12512009/diff/8001/chrome/renderer/chrome_con...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/12512009/diff/8001/chrome/renderer/chrome_con...
chrome/renderer/chrome_content_renderer_client.cc:1128:
WebKit::WebString::fromUTF8(kWebViewTagName));
On 2013/03/18 17:30:48, darin wrote:
> nit: WebString has a using directive up top.

Done.

[commit-bot: I haz the power, 2013-03-18 17:35:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/creis@chromium.org/12512009/13001

[commit-bot: I haz the power, 2013-03-18 21:22:06]

Change committed as 188825